Solution by dimonalek · Pull Request #168 · mate-academy/rda_task_1_create_database

dimonalek · 2026-04-17T07:11:39Z

No description provided.

mateacademy-ai-mentor

Review Summary

I am requesting changes because a few core requirements are not yet met and they will cause the automated tests and checklist checks to fail.

Critical issues that must be fixed:

At the top of task.sql, you currently have USE TestDB;; the task requires operating on a database named ShopDB, so you should add CREATE DATABASE ShopDB; (optionally with IF NOT EXISTS) and USE ShopDB; and remove or replace the USE TestDB; line.
In the Products table, the Description column is defined as TEXT, and Price is DECIMAL(10, 2); the assignment restricts you to INT, DATE, VARCHAR(50), or VARCHAR(100), so change Description to something like VARCHAR(100) and change Price to one of the allowed types (for example, INT if you store cents or VARCHAR(50) if you store a textual price).
In the Customers table definition, the columns are named email and address (lowercase), but the requirement is for Email and Address exactly; rename these columns to match the required capitalization so checks that look for exact names will pass.

Your foreign keys, AUTO_INCREMENT primary keys, and overall table structure look good, so once you adjust the database name, data types, and column names to match the specification, your script should be in great shape for the tests.

✨ Please rate this review in the Platform's notification center¹. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button² in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag³.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

mateacademy-ai-mentor · 2026-04-17T07:13:22Z

@@ -1 +1,28 @@
-# Write your SQL code for the database creation here. Good luck! 
+use TestDB;


The task requires creating a database called ShopDB and running the script in that schema. This line uses TestDB and doesn't create ShopDB. Add CREATE DATABASE ShopDB; and USE ShopDB; (or at least USE ShopDB;) instead of USE TestDB; so the script acts on the required database.

mateacademy-ai-mentor · 2026-04-17T07:13:22Z

+CREATE TABLE Products(
+    ID INT PRIMARY KEY AUTO_INCREMENT,
+    Name VARCHAR(50) NOT NULL,
+    Description TEXT,


The Description column uses type TEXT, which is not allowed by the requirements. Choose one of the permitted types (INT, DATE, VARCHAR(50), or VARCHAR(100)); VARCHAR(100) is appropriate for a product description per the checklist.

mateacademy-ai-mentor · 2026-04-17T07:13:22Z

+    ID INT PRIMARY KEY AUTO_INCREMENT,
+    Name VARCHAR(50) NOT NULL,
+    Description TEXT,
+    Price DECIMAL(10, 2) NOT NULL,


The Price column uses DECIMAL(10, 2), which is not one of the allowed types. Use one of the allowed types (for example, INT if storing price in cents, or VARCHAR(50) if textual) to satisfy the requirement that column types be limited to INT, DATE, VARCHAR(50), or VARCHAR(100).

mateacademy-ai-mentor · 2026-04-17T07:13:22Z

+    ID INT PRIMARY KEY AUTO_INCREMENT,
+    FirstName VARCHAR(50),
+    LastName VARCHAR(50),
+    email VARCHAR(50),


The Customers table must have a column named Email (capital E) per the requirements. This line defines email (lowercase) — rename it to Email to match the specification exactly.

mateacademy-ai-mentor · 2026-04-17T07:13:22Z

+    FirstName VARCHAR(50),
+    LastName VARCHAR(50),
+    email VARCHAR(50),
+    address VARCHAR(100)


The Customers table must have a column named Address (capital A) per the requirements. This line defines address (lowercase) — rename it to Address to match the specification exactly.

mateacademy-ai-mentor

Review Summary

I am requesting changes because the current SQL script still misses some core requirements and is causing the automated tests to fail. First, at the very top of task.sql, you call USE ShopDB; but never create that database, which leads to the ERROR 1049 (42000): Unknown database 'ShopDB'; you need to add CREATE DATABASE IF NOT EXISTS ShopDB; immediately before the USE ShopDB; statement so the database exists on a fresh server. Second, in the Products table definition, the Description column is declared as TEXT and Price as DECIMAL(10,2), but the assignment only allows INT, DATE, VARCHAR(50), and VARCHAR(100); please switch Description to an allowed type such as VARCHAR(100) and choose an allowed type for Price (for example INT if you store the price in cents). Third, in the Customers table, the column names email and address must exactly match the required capitalization Email and Address, so update those identifiers accordingly so name-based checks will pass. After making these fixes, re-run task.sql followed by the provided tests to confirm everything runs without errors. Your table structure and foreign keys are otherwise well set up, so with these adjustments you should fully meet the assignment requirements.

✨ Please rate this review in the Platform's notification center¹. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button² in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag³.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

mateacademy-ai-mentor · 2026-04-17T07:17:24Z

@@ -1 +1,28 @@
-# Write your SQL code for the database creation here. Good luck! 
+use ShopDB;


The task requires the script to create the database named ShopDB. Add CREATE DATABASE ShopDB; (optionally IF NOT EXISTS) before the USE ShopDB; statement so the schema is created on a fresh server and the rest of the script runs within ShopDB.

mateacademy-ai-mentor · 2026-04-17T07:17:24Z

+CREATE TABLE Products(
+    ID INT PRIMARY KEY AUTO_INCREMENT,
+    Name VARCHAR(50) NOT NULL,
+    Description TEXT,


Description is defined as TEXT, but the assignment restricts column types to INT, DATE, VARCHAR(50), or VARCHAR(100). Change this to an allowed type, for example VARCHAR(100).

mateacademy-ai-mentor · 2026-04-17T07:17:24Z

+    ID INT PRIMARY KEY AUTO_INCREMENT,
+    Name VARCHAR(50) NOT NULL,
+    Description TEXT,
+    Price DECIMAL(10, 2) NOT NULL,


Price is currently DECIMAL(10, 2), which is not an allowed type. Use one of the permitted types (for example INT if you store price in cents, or VARCHAR(50)), e.g. Price INT NOT NULL.

mateacademy-ai-mentor · 2026-04-17T07:17:24Z

+    ID INT PRIMARY KEY AUTO_INCREMENT,
+    FirstName VARCHAR(50),
+    LastName VARCHAR(50),
+    email VARCHAR(50),


Column name email uses lowercase. The requirement expects exact capitalization Email. Rename this column to Email to match the specification.

mateacademy-ai-mentor · 2026-04-17T07:17:24Z

+    FirstName VARCHAR(50),
+    LastName VARCHAR(50),
+    email VARCHAR(50),
+    address VARCHAR(100)


Column name address uses lowercase. The requirement expects exact capitalization Address. Rename this column to Address to match the specification.

mateacademy-ai-mentor

Review Summary

I am approving your solution as an educational override so you can keep progressing while you refine the last details. You did a strong job creating all four required tables (Products, Customers, Orders, OrderItems) in ShopDB with appropriate columns, AUTO_INCREMENT primary keys, and foreign keys that correctly use ON DELETE SET NULL, and you also matched the exact capitalization for Customers.Email and Customers.Address. The main remaining issue is near the top of task.sql (around line 1), where you currently have CREATE DATABASE ShopDB; instead of the required CREATE DATABASE IF NOT EXISTS ShopDB; placed immediately before USE ShopDB; — this is important because the tests expect that exact, idempotent statement [CHECKLIST ITEM #1]. To fix this, replace the existing database creation line with the required statement and ensure it appears directly above USE ShopDB;, then re-run task.sql followed by test.sql to confirm everything passes. As a minor improvement, you could make your foreign key columns explicitly NULL or NOT NULL for readability and keep SQL keyword casing consistent (e.g., CREATE, USE, PRIMARY KEY). Overall, your schema design is solid and very close to perfect; with that small database-creation change, it should fully meet all automated checks.

✨ Please rate this review in the Platform's notification center¹. I will be grateful for your feedback! ✨

Rate AI review example ↩

mateacademy-ai-mentor · 2026-04-17T07:20:13Z

@@ -1 +1,29 @@
-# Write your SQL code for the database creation here. Good luck! 
+create database ShopDB;


Replace this line with the required construction CREATE DATABASE IF NOT EXISTS ShopDB; so the database is created idempotently and appears immediately before USE ShopDB; as required by the task.

dimonalek added 2 commits April 17, 2026 10:11

Solution

e20c7ab

Solution

8304ea7

mateacademy-ai-mentor suggested changes Apr 17, 2026

View reviewed changes

dimonalek requested a review from mateacademy-ai-mentor April 17, 2026 07:15

Solution

707f0ad

mateacademy-ai-mentor suggested changes Apr 17, 2026

View reviewed changes

dimonalek requested a review from mateacademy-ai-mentor April 17, 2026 07:19

mateacademy-ai-mentor approved these changes Apr 17, 2026

View reviewed changes

		@@ -1 +1,28 @@
		# Write your SQL code for the database creation here. Good luck!
		use TestDB;

		@@ -1 +1,28 @@
		# Write your SQL code for the database creation here. Good luck!
		use ShopDB;

		@@ -1 +1,29 @@
		# Write your SQL code for the database creation here. Good luck!
		create database ShopDB;

Conversation

dimonalek commented Apr 17, 2026

Uh oh!

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

Review Summary

Footnotes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

Review Summary

Footnotes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

Review Summary

Footnotes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants