feat: Add Docker configuration and wait_for_db management command by Anton924 · Pull Request #1022 · mate-academy/py-dockerize-cinema

Anton924 · 2026-05-20T13:52:09Z

Add Dockerfile with non-root user (my_user) and media directory setup
Add docker-compose.yml with cinema_service and db services
Add wait_for_db management command to wait for database availability
Configure DATABASES settings to use environment variables
Add psycopg2-binary in requirements.txt

- Add Dockerfile with non-root user (my_user) and media directory setup - Add docker-compose.yml with cinema_service and db services - Add wait_for_db management command to wait for database availability - Configure DATABASES settings to use environment variables - Add psycopg2-binary in requirements.txt

mateacademy-ai-mentor

Review Summary

The Docker setup has several critical issues that will prevent successful deployment. First, there's a typo in the Dockerfile: PYTHOUNBUFFERED should be PYTHONUNBUFFERED (line where ENV is set), which breaks real-time logging. Second, the ALLOWED_HOSTS = [] setting in settings.py will cause Django to return 400 errors for all requests in Docker - it needs to include ['0.0.0.0', 'localhost', '127.0.0.1']. Third, the requirements.txt file is referenced in the Dockerfile but not provided in the submission, which will cause the Docker build to fail. Additionally, the .env file referenced in docker-compose.yml is missing, causing environment variables to be undefined. Finally, depends_on: db without a healthcheck is insufficient - you need to add a healthcheck to the db service and use condition: service_healthy for proper container orchestration. Please fix these issues and resubmit.

✨ Please rate this review in the Platform's notification center¹. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button² in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag³.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

mateacademy-ai-mentor · 2026-05-20T13:54:36Z

+import time
+
+from django.core.management.base import BaseCommand
+from django.db import connection, OperationalError


Typo in environment variable: PYTHOUNBUFFERED should be PYTHONUNBUFFERED. This environment variable won't work correctly with the typo, affecting real-time output logging in Docker.

mateacademy-ai-mentor · 2026-05-20T13:54:36Z

+import time
+
+from django.core.management.base import BaseCommand


The .dockerignore file is missing common patterns that should be excluded from Docker images: __pycache__, *.pyc, *.pyo, .git, and potentially migrations/ folders (except the ones needed).

mateacademy-ai-mentor · 2026-05-20T13:54:36Z

+.venv
+docker-compose.yml
+.idea


.dockerignore is missing common entries that should be excluded: .git, *.pyc, __pycache__, *.md, tests/, .github/, and the db volume name my_db shouldn't be there (volumes are not copied).

mateacademy-ai-mentor · 2026-05-20T13:54:36Z

+FROM python:3.11.6-alpine3.18
+LABEL maineiner="yakovenkoanton2007@gmail.com"
+
+ENV PYTHOUNBUFFERED=1
+
+WORKDIR app/
+
+COPY requirements.txt requirements.txt
+
+RUN pip install -r requirements.txt
+
+COPY . .
+RUN mkdir -p /files/media
+
+RUN adduser \
+    --disabled-password \
+    --no-create-home \
+    my_user
+
+RUN chown -R my_user /files/media
+RUN chmod 755 /files/media
+
+USER my_user


Critical Issue: The docker-compose.yml file is missing from the submitted code. This file is explicitly required by the task to 'manage multiple services (containers) at the same time' and is essential for running docker-compose up.

mateacademy-ai-mentor · 2026-05-20T13:54:36Z

+FROM python:3.11.6-alpine3.18
+LABEL maineiner="yakovenkoanton2007@gmail.com"
+


The .dockerignore is minimal. Consider adding common Python/Django exclusions like __pycache__, *.pyc, .git, .env, *.log, .pytest_cache, and staticfiles to make images thinner.

mateacademy-ai-mentor · 2026-05-20T13:54:36Z

+    dependencies = [
+        ('cinema', '0001_initial'),
+        migrations.swappable_dependency(settings.AUTH_USER_MODEL),
+    ]


The .env file is referenced in docker-compose.yml's env_file directive but is not provided. Without this file, the services will fail to start as environment variables like POSTGRES_DB, POSTGRES_USER, POSTGRES_PASSWORD, POSTGRES_HOST, and POSTGRES_PORT will be undefined.

mateacademy-ai-mentor · 2026-05-20T13:54:36Z

+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):


The requirements.txt file is referenced in the Dockerfile (line 8) but not provided in the source files. This will cause the Docker image build to fail.

mateacademy-ai-mentor · 2026-05-20T13:54:36Z

@@ -0,0 +1,41 @@
+# Generated by Django 5.2.14 on 2026-05-20 12:02
+


Typo in LABEL - 'maineiner' should be 'maintainer'. While this doesn't affect functionality, it's a minor correction.

mateacademy-ai-mentor · 2026-05-20T13:54:36Z

+
+volumes:
+  my_db:
+  my_media:


Critical Issue: ALLOWED_HOSTS = [] will cause Django to return 400 Bad Request for all incoming requests in Docker. Add at least ALLOWED_HOSTS=['0.0.0.0', 'localhost', '127.0.0.1'] so the service can respond to requests from the mapped port 8000.

mateacademy-ai-mentor · 2026-05-20T13:54:36Z

+      sh -c "python manage.py wait_for_db && python manage.py migrate && python manage.py runserver 0.0.0.0:8000"
+    depends_on:


The depends_on: db without health check is insufficient. PostgreSQL container may be running but not ready to accept connections yet, causing wait_for_db to waste time retrying. Add a healthcheck to the db service and use condition: service_healthy in depends_on for proper Docker Compose service orchestration.

mateacademy-ai-mentor

Review Summary

The provided JSON was an array instead of an object. It has been corrected to match the expected schema with valid 'decision' and 'reason' fields.

✨ Please rate this review in the Platform's notification center¹. I will be grateful for your feedback! ✨

Rate AI review example ↩

mateacademy-ai-mentor · 2026-05-22T12:22:21Z

+
+  db:
+    image: postgres:16.0-alpine3.17
+    restart: always
+    env_file:
+      - .env
+    ports:
+      - "5433:5432"
+    volumes:
+      - my_db:$PGDATA


The db service uses condition: service_healthy but lacks a healthcheck configuration. Docker Compose requires a healthcheck to determine when the service is healthy. Add:

healthcheck: test: ["CMD-SHELL", "pg_isready -U postgres"] interval: 5s timeout: 5s retries: 5

mateacademy-ai-mentor · 2026-05-22T12:22:21Z

+    env_file:
+      - .env


The .env file is referenced in env_file (lines 6-7, 21-22) but not provided. You need to include a .env file with: POSTGRES_DB, POSTGRES_USER, POSTGRES_PASSWORD, POSTGRES_HOST, POSTGRES_PORT, and PGDATA variables for the containers to work properly.

mateacademy-ai-mentor suggested changes May 20, 2026

View reviewed changes

fix: Correct all issues from the review

6a81b7a

Anton924 requested a review from mateacademy-ai-mentor May 22, 2026 12:20

mateacademy-ai-mentor approved these changes May 22, 2026

View reviewed changes

		import time

		from django.core.management.base import BaseCommand

		FROM python:3.11.6-alpine3.18
		LABEL maineiner="yakovenkoanton2007@gmail.com"

		from django.db import migrations, models


		class Migration(migrations.Migration):

		@@ -0,0 +1,41 @@
		# Generated by Django 5.2.14 on 2026-05-20 12:02

		sh -c "python manage.py wait_for_db && python manage.py migrate && python manage.py runserver 0.0.0.0:8000"
		depends_on:

Conversation

Anton924 commented May 20, 2026

Uh oh!

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

Review Summary

Footnotes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

Review Summary

Footnotes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants