-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Soulution #1162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
maxbidun
wants to merge
4
commits into
mate-academy:master
Choose a base branch
from
maxbidun:develop
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Soulution #1162
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
47 changes: 47 additions & 0 deletions
47
cinema/migrations/0002_actor_cinemahall_genre_movie_actors_movie_genres.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| # Generated by Django 4.1 on 2026-05-13 03:57 | ||
|
|
||
| from django.db import migrations, models | ||
|
|
||
|
|
||
| class Migration(migrations.Migration): | ||
|
|
||
| dependencies = [ | ||
| ('cinema', '0001_initial'), | ||
| ] | ||
|
|
||
| operations = [ | ||
| migrations.CreateModel( | ||
| name='Actor', | ||
| fields=[ | ||
| ('id', models.BigAutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID')), | ||
| ('first_name', models.CharField(max_length=255)), | ||
| ('last_name', models.CharField(max_length=255)), | ||
| ], | ||
| ), | ||
| migrations.CreateModel( | ||
| name='CinemaHall', | ||
| fields=[ | ||
| ('id', models.BigAutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID')), | ||
|
maxbidun marked this conversation as resolved.
|
||
| ('name', models.CharField(max_length=255)), | ||
| ('rows', models.IntegerField()), | ||
| ('seats_in_row', models.IntegerField()), | ||
| ], | ||
| ), | ||
| migrations.CreateModel( | ||
|
maxbidun marked this conversation as resolved.
|
||
| name='Genre', | ||
| fields=[ | ||
| ('id', models.BigAutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID')), | ||
| ('name', models.CharField(max_length=255)), | ||
| ], | ||
| ), | ||
| migrations.AddField( | ||
| model_name='movie', | ||
| name='actors', | ||
| field=models.ManyToManyField(related_name='movies', to='cinema.actor'), | ||
| ), | ||
| migrations.AddField( | ||
| model_name='movie', | ||
| name='genres', | ||
| field=models.ManyToManyField(related_name='movies', to='cinema.genre'), | ||
| ), | ||
| ] | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,31 @@ | ||
| from django.contrib.auth.models import AbstractUser | ||
| from django.db import models | ||
|
|
||
| class Actor(models.Model): | ||
| first_name = models.CharField(max_length=255) | ||
| last_name = models.CharField(max_length=255) | ||
|
|
||
| class Genre(models.Model): | ||
| name = models.CharField(max_length=255) | ||
|
maxbidun marked this conversation as resolved.
Outdated
|
||
|
|
||
| def __str__(self) -> str: | ||
| return self.name | ||
|
|
||
|
|
||
| class CinemaHall(models.Model): | ||
| name = models.CharField(max_length=255) | ||
| rows = models.IntegerField() | ||
| seats_in_row = models.IntegerField() | ||
|
|
||
| def __str__(self) -> str: | ||
| return self.name | ||
|
|
||
| class Movie(models.Model): | ||
| title = models.CharField(max_length=255) | ||
|
maxbidun marked this conversation as resolved.
|
||
| description = models.TextField() | ||
| duration = models.IntegerField() | ||
| actors = models.ManyToManyField(Actor, related_name="movies") | ||
| genres = models.ManyToManyField(Genre, related_name="movies") | ||
|
|
||
| def __str__(self): | ||
| def __str__(self) -> str: | ||
| return self.title | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,33 @@ | ||
| from django.urls import include | ||
|
|
||
| from django.urls import path | ||
| from rest_framework import routers | ||
|
|
||
| from cinema.views import GenreList, GenreDetail, ActorList, ActorDetail, MovieViewSet | ||
| from cinema.views import CinemaHallViewSet | ||
|
|
||
| cinema_hall_list = CinemaHallViewSet.as_view(actions={ | ||
|
maxbidun marked this conversation as resolved.
Outdated
|
||
| 'get': 'list', 'post': 'create' | ||
| }) | ||
|
|
||
| cinema_hall_detail = CinemaHallViewSet.as_view(actions={ | ||
| 'get': 'retrieve', | ||
| 'put': 'update', | ||
| 'patch': 'partial_update', | ||
| 'delete': 'destroy' | ||
| }) | ||
|
|
||
| from cinema.views import movie_list, movie_detail | ||
| router = routers.DefaultRouter() | ||
| router.register('movies', MovieViewSet) | ||
|
|
||
| urlpatterns = [ | ||
| path("movies/", movie_list, name="movie-list"), | ||
| path("movies/<int:pk>/", movie_detail, name="movie-detail"), | ||
| path("cinemahalls/", cinema_hall_list, name="cinema-hall-list"), | ||
|
maxbidun marked this conversation as resolved.
Outdated
|
||
| path("cinemahalls/<int:pk>/", cinema_hall_detail, name="cinema-detail"), | ||
| path("genres/", GenreList.as_view(), name="genre-list"), | ||
| path("genres/<int:pk>/", GenreDetail.as_view(), name="genre-detail"), | ||
| path("actors/", ActorList.as_view(), name="actor-list"), | ||
| path("actors/<int:pk>/", ActorDetail.as_view(), name="actor-detail"), | ||
| path("", include(router.urls)), | ||
| ] | ||
|
|
||
| app_name = "cinema" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,45 +1,101 @@ | ||
| from rest_framework.decorators import api_view | ||
| from rest_framework.response import Response | ||
| from rest_framework import status | ||
| from rest_framework import status, viewsets, generics, mixins | ||
|
|
||
| from django.shortcuts import get_object_or_404 | ||
| from rest_framework.views import APIView | ||
| from rest_framework.viewsets import GenericViewSet | ||
|
|
||
| from cinema.models import Movie | ||
| from cinema.serializers import MovieSerializer | ||
| from cinema.models import Movie, Genre, Actor, CinemaHall | ||
| from cinema.serializers import MovieSerializer, GenreSerializer, ActorSerializer, CinemaHallSerializer | ||
|
|
||
|
|
||
| @api_view(["GET", "POST"]) | ||
| def movie_list(request): | ||
| if request.method == "GET": | ||
| movies = Movie.objects.all() | ||
| serializer = MovieSerializer(movies, many=True) | ||
| # @api_view(["GET", "POST"]) | ||
| # def movie_list(request): | ||
| # if request.method == "GET": | ||
| # movies = Movie.objects.all() | ||
| # serializer = MovieSerializer(movies, many=True) | ||
| # return Response(serializer.data, status=status.HTTP_200_OK) | ||
| # | ||
| # if request.method == "POST": | ||
| # serializer = MovieSerializer(data=request.data) | ||
| # if serializer.is_valid(): | ||
| # serializer.save() | ||
| # return Response(serializer.data, status=status.HTTP_201_CREATED) | ||
| # | ||
| # return Response(serializer.errors, status=status.HTTP_400_BAD_REQUEST) | ||
| # | ||
| # | ||
| # @api_view(["GET", "PUT", "DELETE"]) | ||
| # def movie_detail(request, pk): | ||
| # movie = get_object_or_404(Movie, pk=pk) | ||
| # | ||
| # if request.method == "GET": | ||
| # serializer = MovieSerializer(movie) | ||
| # return Response(serializer.data, status=status.HTTP_200_OK) | ||
| # | ||
| # if request.method == "PUT": | ||
| # serializer = MovieSerializer(movie, data=request.data) | ||
| # if serializer.is_valid(): | ||
| # serializer.save() | ||
| # return Response(serializer.data, status=status.HTTP_200_OK) | ||
| # | ||
| # return Response(serializer.errors, status=status.HTTP_400_BAD_REQUEST) | ||
| # | ||
| # if request.method == "DELETE": | ||
| # movie.delete() | ||
| # return Response(status=status.HTTP_204_NO_CONTENT) | ||
|
|
||
| class MovieViewSet(viewsets.ModelViewSet): | ||
| queryset = Movie.objects.all() | ||
| serializer_class = MovieSerializer | ||
|
|
||
|
|
||
| class GenreList(APIView): | ||
| def get(self, request): | ||
| genres = Genre.objects.all() | ||
| serializer = GenreSerializer(genres, many=True) | ||
| return Response(serializer.data, status=status.HTTP_200_OK) | ||
|
|
||
| if request.method == "POST": | ||
| serializer = MovieSerializer(data=request.data) | ||
| if serializer.is_valid(): | ||
| serializer.save() | ||
| return Response(serializer.data, status=status.HTTP_201_CREATED) | ||
| def post(self, request): | ||
| serializer = GenreSerializer(data=request.data) | ||
| serializer.is_valid(raise_exception=True) | ||
| serializer.save() | ||
| return Response(serializer.data, status=status.HTTP_201_CREATED) | ||
|
|
||
| return Response(serializer.errors, status=status.HTTP_400_BAD_REQUEST) | ||
|
|
||
| class GenreDetail(APIView): | ||
| def get_object(self, pk): | ||
| return get_object_or_404(Genre, pk=pk) | ||
|
|
||
| @api_view(["GET", "PUT", "DELETE"]) | ||
| def movie_detail(request, pk): | ||
| movie = get_object_or_404(Movie, pk=pk) | ||
| def get(self, request, pk): | ||
| genre = self.get_object(pk) | ||
| serializer = GenreSerializer(genre) | ||
| return Response(serializer.data, status=status.HTTP_200_OK) | ||
|
|
||
| if request.method == "GET": | ||
| serializer = MovieSerializer(movie) | ||
| def put(self, request, pk): | ||
| genre = self.get_object(pk) | ||
| serializer = GenreSerializer(genre, data=request.data) | ||
| serializer.is_valid(raise_exception=True) | ||
| serializer.save() | ||
| return Response(serializer.data, status=status.HTTP_200_OK) | ||
|
|
||
| if request.method == "PUT": | ||
| serializer = MovieSerializer(movie, data=request.data) | ||
| if serializer.is_valid(): | ||
| serializer.save() | ||
| return Response(serializer.data, status=status.HTTP_200_OK) | ||
| def delete(self, request, pk): | ||
| genre = self.get_object(pk) | ||
| genre.delete() | ||
| return Response(status=status.HTTP_204_NO_CONTENT) | ||
|
|
||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Task requirement specifies: 'For the Actor model use a GenericAPIView'. The current implementation uses |
||
| class ActorList(generics.ListCreateAPIView): | ||
| queryset = Actor.objects.all() | ||
| serializer_class = ActorSerializer | ||
|
|
||
|
|
||
|
maxbidun marked this conversation as resolved.
|
||
| class ActorDetail(generics.RetrieveUpdateAPIView): | ||
| queryset = Actor.objects.all() | ||
| serializer_class = ActorSerializer | ||
|
|
||
| class CinemaHallViewSet(mixins.ListModelMixin,mixins.CreateModelMixin,mixins.RetrieveModelMixin,mixins.UpdateModelMixin,mixins.DestroyModelMixin,viewsets.GenericViewSet): | ||
| queryset = CinemaHall.objects.all() | ||
| serializer_class = CinemaHallSerializer | ||
|
|
||
| return Response(serializer.errors, status=status.HTTP_400_BAD_REQUEST) | ||
|
|
||
| if request.method == "DELETE": | ||
| movie.delete() | ||
| return Response(status=status.HTTP_204_NO_CONTENT) | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.