Skip to content
Open

Develop #1161

Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .flake8
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,6 @@ max-complexity = 18
select = B,C,E,F,W,T4,B9,Q0,N8,VNE
exclude =
**migrations
venv
tests
.venv1
tests
.\cinema_service\settings.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,71 @@
# Generated by Django 4.1 on 2026-05-09 18:35

from django.db import migrations, models


class Migration(migrations.Migration):

dependencies = [
("cinema", "0001_initial"),
]

operations = [
migrations.CreateModel(
name="Actor",
fields=[
(
"id",
models.BigAutoField(
auto_created=True,
primary_key=True,
serialize=False,
verbose_name="ID",
),
),
("first_name", models.CharField(max_length=255)),
("last_name", models.CharField(max_length=255)),
],
),
migrations.CreateModel(
Comment on lines +14 to +29
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ManyToMany fields cannot be assigned directly like this. After saving the instance, use instance.actors.set(actors) and instance.genres.set(genres) to properly update the M2M relationships. The current code will fail to persist actors and genres to the database.

name="CinemaHall",
fields=[
(
"id",
models.BigAutoField(
auto_created=True,
primary_key=True,
serialize=False,
verbose_name="ID",
),
),
("name", models.CharField(max_length=255)),
("rows", models.IntegerField()),
("seats_in_row", models.IntegerField()),
],
),
migrations.CreateModel(
name="Genre",
fields=[
(
"id",
models.BigAutoField(
auto_created=True,
primary_key=True,
serialize=False,
verbose_name="ID",
),
),
("name", models.CharField(max_length=255, unique=True)),
],
),
migrations.AddField(
model_name="movie",
name="actors",
field=models.ManyToManyField(related_name="movies", to="cinema.actor"),
),
migrations.AddField(
model_name="movie",
name="genres",
field=models.ManyToManyField(related_name="movies", to="cinema.genre"),
),
]
23 changes: 23 additions & 0 deletions cinema/models.py
Original file line number Diff line number Diff line change
@@ -1,9 +1,32 @@
from django.db import models


class Actor(models.Model):
first_name = models.CharField(max_length=255)
last_name = models.CharField(max_length=255)


class Genre(models.Model):
name = models.CharField(max_length=255, unique=True)

def __str__(self):
return self.name


class CinemaHall(models.Model):
name = models.CharField(max_length=255)
rows = models.IntegerField()
seats_in_row = models.IntegerField()

def __str__(self):
return self.name


class Movie(models.Model):
title = models.CharField(max_length=255)
description = models.TextField()
actors = models.ManyToManyField(Actor, related_name="movies")
genres = models.ManyToManyField(Genre, related_name="movies")
duration = models.IntegerField()

def __str__(self):
Expand Down
82 changes: 79 additions & 3 deletions cinema/serializers.py
Original file line number Diff line number Diff line change
@@ -1,24 +1,100 @@
from rest_framework import serializers

from cinema.models import Movie
from cinema.models import Movie, Actor, Genre, CinemaHall


class MovieSerializer(serializers.Serializer):
id = serializers.IntegerField(read_only=True)
actors = serializers.PrimaryKeyRelatedField(
many=True,
queryset=Actor.objects.all()
)
genres = serializers.PrimaryKeyRelatedField(
many=True,
queryset=Genre.objects.all()
)
title = serializers.CharField(max_length=255)
description = serializers.CharField()
duration = serializers.IntegerField()

def create(self, validated_data):
return Movie.objects.create(**validated_data)
actors_data = validated_data.pop("actors")
genres_data = validated_data.pop("genres")

movie = Movie.objects.create(**validated_data)

movie.actors.set(actors_data)
movie.genres.set(genres_data)

return movie

def update(self, instance, validated_data):
actors_data = validated_data.pop("actors", None)
genres_data = validated_data.pop("genres", None)

instance.title = validated_data.get("title", instance.title)
instance.description = validated_data.get(
"description", instance.description
"description",
instance.description
)
instance.duration = validated_data.get("duration", instance.duration)

instance.save()

if actors_data is not None:
instance.actors.set(actors_data)
if genres_data is not None:
instance.genres.set(genres_data)

return instance
Comment on lines 31 to 49
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The update() method doesn't handle ManyToMany relationships. After updating basic fields, you need to check if actors/genres are in validated_data and update them using .set().



class ActorSerializer(serializers.Serializer):
id = serializers.IntegerField(read_only=True)
first_name = serializers.CharField(max_length=255)
last_name = serializers.CharField(max_length=255)

def create(self, validated_data):
return Actor.objects.create(**validated_data)

def update(self, instance, validated_data):
instance.first_name = validated_data.get(
"first_name", instance.first_name
)
instance.last_name = validated_data.get(
"last_name", instance.last_name
)
instance.save()
return instance


class GenreSerializer(serializers.Serializer):
id = serializers.IntegerField(read_only=True)
name = serializers.CharField(max_length=255)

def create(self, validated_data):
return Genre.objects.create(**validated_data)

def update(self, instance, validated_data):
instance.name = validated_data.get("name", instance.name)
instance.save()
return instance


class CinemaHallSerializer(serializers.Serializer):
id = serializers.IntegerField(read_only=True)
name = serializers.CharField(max_length=255)
rows = serializers.IntegerField()
seats_in_row = serializers.IntegerField()

def create(self, validated_data):
return CinemaHall.objects.create(**validated_data)

def update(self, instance, validated_data):
instance.name = validated_data.get("name", instance.name)
instance.rows = validated_data.get("rows", instance.rows)
instance.seats_in_row = validated_data.get(
"seats_in_row", instance.seats_in_row
)
instance.save()
return instance
44 changes: 40 additions & 4 deletions cinema/urls.py
Original file line number Diff line number Diff line change
@@ -1,10 +1,46 @@
from django.urls import path
from django.urls import path, include
from rest_framework import routers

from cinema.views import movie_list, movie_detail
from cinema.views import (
ActorList,
ActorDetail,
GenreList,
GenreDetail,
CinemaHallViewSet,
MovieViewSet,
)

cinema_hall_list = CinemaHallViewSet.as_view(
actions={
"get": "list",
Comment on lines +13 to +15
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ManyToMany fields cannot be passed directly to objects.create(). The object must be created first, then M2M relationships assigned using .set(). Pop actors and genres from validated_data before creating the instance, then call instance.actors.set(actors) and instance.genres.set(genres) after creation.

"post": "create"
}
)

cinema_hall_detail = CinemaHallViewSet.as_view(
Comment on lines +17 to +20
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Direct assignment to M2M fields (instance.actors = ...) doesn't work. You must use instance.actors.set(...) for ManyToMany relationships. Pop these fields from validated_data and use .set() instead of direct assignment.

actions={
"get": "retrieve",
"put": "update",
"patch": "partial_update",
"delete": "destroy",
}
)

routers = routers.DefaultRouter()
routers.register("movies", MovieViewSet)

urlpatterns = [
path("movies/", movie_list, name="movie-list"),
path("movies/<int:pk>/", movie_detail, name="movie-detail"),
path("", include(routers.urls)),
path("genres/", GenreList.as_view(), name="genre-list"),
path("genres/<int:pk>/", GenreDetail.as_view(), name="genre-detail"),
path("actors/", ActorList.as_view(), name="actor-list"),
path("actors/<int:pk>/", ActorDetail.as_view(), name="actor-detail"),
path("cinema_halls/", cinema_hall_list, name="cinema-hall-list"),
path(
"cinema_halls/<int:pk>/",
cinema_hall_detail,
name="cinema-hall-detail"
),
]

app_name = "cinema"
Loading
Loading