Skip to content
Open
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion cinema/admin.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,21 @@
from django.contrib import admin

from cinema.models import Movie
from cinema.models import Actor, Genre, CinemaHall, Movie


@admin.register(Actor)
class ActorAdmin(admin.ModelAdmin):
pass


@admin.register(Genre)
class GenreAdmin(admin.ModelAdmin):
pass


@admin.register(CinemaHall)
class CinemaHallAdmin(admin.ModelAdmin):
pass


@admin.register(Movie)
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,71 @@
# Generated by Django 4.1 on 2026-04-10 12:03

from django.db import migrations, models


class Migration(migrations.Migration):

dependencies = [
("cinema", "0001_initial"),
]

operations = [
migrations.CreateModel(
name="Actor",
fields=[
(
"id",
models.BigAutoField(
auto_created=True,
primary_key=True,
serialize=False,
verbose_name="ID",
),
),
("first_name", models.CharField(max_length=255)),
("last_name", models.CharField(max_length=255)),
],
),
migrations.CreateModel(
name="CinemaHall",
fields=[
(
"id",
models.BigAutoField(
auto_created=True,
primary_key=True,
serialize=False,
verbose_name="ID",
),
),
("name", models.CharField(max_length=255)),
("rows", models.IntegerField()),
("seat_in_row", models.IntegerField()),
],
),
migrations.CreateModel(
name="Genre",
fields=[
(
"id",
models.BigAutoField(
auto_created=True,
primary_key=True,
serialize=False,
verbose_name="ID",
),
),
("name", models.CharField(max_length=255, unique=True)),
],
),
migrations.AddField(
model_name="movie",
name="actors",
field=models.ManyToManyField(related_name="movies", to="cinema.actor"),
),
migrations.AddField(
model_name="movie",
name="genres",
field=models.ManyToManyField(related_name="movies", to="cinema.genre"),
),
]
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
# Generated by Django 4.1 on 2026-04-10 12:11

from django.db import migrations


class Migration(migrations.Migration):

dependencies = [
("cinema", "0002_actor_cinemahall_genre_movie_actors_movie_genres"),
]

operations = [
migrations.RenameField(
model_name="cinemahall",
old_name="seat_in_row",
new_name="seats_in_row",
),
]
26 changes: 26 additions & 0 deletions cinema/models.py
Original file line number Diff line number Diff line change
@@ -1,10 +1,36 @@
from django.db import models


class Actor(models.Model):
first_name = models.CharField(max_length=255)
last_name = models.CharField(max_length=255)

def __str__(self):
return f"{self.first_name} {self.last_name}"


class Genre(models.Model):
name = models.CharField(max_length=255, unique=True)

def __str__(self):
return self.name

Comment on lines +16 to +17
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The router registers 'Movies' with capital M. Per the task requirements, the endpoint should be 'movies' (lowercase). The task specifies 'api/cinema//' pattern with entities like 'actors', 'genres', 'cinema_halls', 'movies'.


class CinemaHall(models.Model):
name = models.CharField(max_length=255)
rows = models.IntegerField()
seats_in_row = models.IntegerField()

def __str__(self):
return f"{self.name}, rows: {self.rows} (seats: {self.seats_in_row})"


class Movie(models.Model):
title = models.CharField(max_length=255)
description = models.TextField()
duration = models.IntegerField()
actors = models.ManyToManyField(Actor, related_name="movies")
genres = models.ManyToManyField(Genre, related_name="movies")

def __str__(self):
return self.title
70 changes: 63 additions & 7 deletions cinema/serializers.py
Original file line number Diff line number Diff line change
@@ -1,24 +1,80 @@
from rest_framework import serializers

from cinema.models import Movie
from cinema.models import Actor, Genre, CinemaHall, Movie
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused import. The 'api_view' decorator is imported but never used in this file.



class ActorSerializer(serializers.ModelSerializer):
id = serializers.IntegerField(read_only=True)
first_name = serializers.CharField(max_length=255)
last_name = serializers.CharField(max_length=255)

def create(self, validated_data):
return Actor.objects.create(**validated_data)

def update(self, instance, validated_data):
instance.first_name = validated_data.get("first_name", instance.first_name)
instance.last_name = validated_data.get("last_name", instance.last_name)
instance.save()
return instance


class GenreSerializer(serializers.ModelSerializer):
id = serializers.IntegerField(read_only=True)
name = serializers.CharField(max_length=255)

def create(self, validated_data):
return Genre.objects.create(**validated_data)

def update(self, instance, validated_data):
instance.name = validated_data.get("name", instance.name)
instance.save()
return instance


class CinemaHallSerializer(serializers.ModelSerializer):
id = serializers.IntegerField(read_only=True)
name = serializers.CharField(max_length=255)
rows = serializers.IntegerField()
seats_in_row = serializers.IntegerField()

def create(self, validated_data):
return CinemaHall.objects.create(**validated_data)

def update(self, instance, validated_data):
Comment on lines +40 to +61
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GenreDetail is missing the PATCH method for partial updates. The task specifies: 'PATCH api/cinema///' - should partially update the entity with given id based on passed data.

instance.name = validated_data.get("name", instance.name)
instance.rows = validated_data.get("rows", instance.rows)
instance.seats_in_row = validated_data.get(
"seats_in_row", instance.seats_in_row
)
instance.save()
return instance


class MovieSerializer(serializers.Serializer):
id = serializers.IntegerField(read_only=True)
title = serializers.CharField(max_length=255)
description = serializers.CharField()
duration = serializers.IntegerField()
actors = serializers.PrimaryKeyRelatedField(many=True, queryset=Actor.objects.all())
genres = serializers.PrimaryKeyRelatedField(many=True, queryset=Genre.objects.all())

def create(self, validated_data):
return Movie.objects.create(**validated_data)
actors = validated_data.pop("actors")
genres = validated_data.pop("genres")
movie = Movie.objects.create(**validated_data)
movie.actors.set(actors)
movie.genres.set(genres)
return movie

def update(self, instance, validated_data):
actors = validated_data.pop("actors", None)
genres = validated_data.pop("genres", None)
instance.title = validated_data.get("title", instance.title)
instance.description = validated_data.get(
"description", instance.description
)
instance.description = validated_data.get("description", instance.description)
instance.duration = validated_data.get("duration", instance.duration)

instance.save()

if actors is not None:
instance.actors.set(actors)
if genres is not None:
instance.genres.set(genres)
return instance
31 changes: 25 additions & 6 deletions cinema/urls.py
Original file line number Diff line number Diff line change
@@ -1,10 +1,29 @@
from django.urls import path
from django.urls import path, include

from cinema.views import movie_list, movie_detail
from rest_framework.routers import DefaultRouter

urlpatterns = [
path("movies/", movie_list, name="movie-list"),
path("movies/<int:pk>/", movie_detail, name="movie-detail"),
]
from cinema.views import (
GenreList,
GenreDetail,
ActorList,
ActorDetail,
CinemaHallViewSet,
MovieViewSet,
)

app_name = "cinema"

router = DefaultRouter()
router.register("cinema-halls", CinemaHallViewSet)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The router registers 'Movies' (capitalized) instead of 'movies'. Per the task requirements, the endpoint should use lowercase: 'api/cinema///' where includes 'movies', 'actors', 'genres', 'cinema_halls'.

router.register("movies", MovieViewSet)

urlpatterns = [
# Genre
path("genres/", GenreList.as_view(), name="genre-list"),
path("genres/<int:pk>/", GenreDetail.as_view(), name="genre-detail"),
# Actor
path("actors/", ActorList.as_view(), name="actor-list"),
path("actors/<int:pk>/", ActorDetail.as_view(), name="actor-detail"),
# ViewSet
path("", include(router.urls)),
]
Loading
Loading