Skip to content
Open
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions .github/workflows/test.yml-template
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
name: Test

on:
pull_request:
branches: [ master ]

jobs:
build:

runs-on: ubuntu-latest

strategy:
matrix:
node-version: [20.x]

steps:
- uses: actions/checkout@v2
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node-version }}
- run: npm install
- run: npm test
9 changes: 5 additions & 4 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"license": "GPL-3.0",
"devDependencies": {
"@mate-academy/eslint-config": "latest",
"@mate-academy/scripts": "^1.8.6",
"@mate-academy/scripts": "^2.1.3",
"axios": "^1.7.2",
"eslint": "^8.57.0",
"eslint-plugin-jest": "^28.6.0",
Expand Down
33 changes: 31 additions & 2 deletions src/createServer.js
Original file line number Diff line number Diff line change
@@ -1,9 +1,38 @@
/* eslint-disable no-console */
'use strict';

const http = require('http');

function createServer() {
/* Write your code here */
// Return instance of http.Server class
const server = http.createServer((req, res) => {
let parts;

res.setHeader('Content-Type', 'application/json');

if (!req.url) {
res.end();

return;
}

const urlArguments = req.url.split('?');

if (urlArguments[0].includes('//')) {
parts = urlArguments[0].slice(2).split('//');
} else {
parts = urlArguments[0].slice(1).split('/');
}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This logic for handling pathname parsing is not yet correct. It fails on several cases required by the task, for example, a path like //hello/world will result in ['hello/world'] instead of ['hello', 'world'].

A more robust approach that handles all cases (leading slashes, double slashes, trailing slashes) is to split the path by / and then filter out any resulting empty strings.


const query = Object.fromEntries(new URLSearchParams(urlArguments[1]));

const result = { parts: parts, query: query };

console.log(parts, query);

res.end(JSON.stringify(result));
});

return server;
}

module.exports = {
Expand Down
Loading