Skip to content
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions .github/workflows/test.yml-template
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
name: Test

on:
pull_request:
branches: [ master ]

jobs:
build:

runs-on: ubuntu-latest

strategy:
matrix:
node-version: [20.x]

steps:
- uses: actions/checkout@v2
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node-version }}
- run: npm install
- run: npm test
9 changes: 5 additions & 4 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"license": "GPL-3.0",
"devDependencies": {
"@mate-academy/eslint-config": "latest",
"@mate-academy/scripts": "^1.8.6",
"@mate-academy/scripts": "^2.1.3",
"axios": "^1.7.2",
"eslint": "^8.57.0",
"eslint-plugin-jest": "^28.6.0",
Expand Down
22 changes: 20 additions & 2 deletions src/createServer.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,26 @@
'use strict';

function createServer() {
/* Write your code here */
// Return instance of http.Server class
const server = require('http').createServer((req, res) => {
res.setHeader('Content-Type', 'application/json');

const [, query] = req.url.split('?');
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line manually extracts the query string, but the URL object you create on line 10 already does this for you. You can get a URLSearchParams object directly from url.searchParams. Using it would allow you to remove this line and line 12, making the code more direct.


const url = new URL(req.url, `http://${req.headers.host}`);
const path = url.pathname;
const params = new URLSearchParams(query);
const paramsObj = Object.fromEntries(params.entries());

const result = {
parts: path.split('/').filter(Boolean),
query: paramsObj,
};

res.statusCode = 200;
res.end(JSON.stringify(result));
});

return server;
}

module.exports = {
Expand Down