Skip to content

Implement node form data solution #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AnnNikiforova wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Implement node form data solution #161

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e29f888
Implement node form data solution
AnnNikiforova Aug 15, 2025
68cdfe7
Implement node form data solution
AnnNikiforova Aug 15, 2025
2f619bc
Fix the issues
AnnNikiforova Aug 15, 2025
fbdefb4
Fix the issues 2
AnnNikiforova Aug 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 43 additions & 0 deletions public/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
<html lang="en">
<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>Form data</title>
</head>
<body>
<h1>Form data for expense</h1>
<form action="/add-expense" method="POST">
<label for="date">Date:</label><br>
<input
type="date"
name="date"
id="date"
required
/>

<br><br>

<label for="title">Title:</label><br>
<input
id="title"
name="title"
type="text"
required
/>

<br><br>

<label for="amount">Amount:</label><br>
<input
type="number"
name="amount"
id="amount"
required
/>

<br><br>

<button type="submit">Send request</button>
</form>
</body>
</html>
109 changes: 106 additions & 3 deletions src/createServer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,111 @@
'use strict';
const http = require('node:http');
const fs = require('node:fs');
const path = require('node:path');

function createServer() {
/* Write your code here */
// Return instance of http.Server class
const server = http.createServer((req, res) => {
const reqUrl = new URL(req.url || '', `http://${req.headers.host}`);
const pathname = reqUrl.pathname;

if (req.method === 'GET' && pathname === '/') {
const indexPath = path.resolve('public', 'index.html');

res.statusCode = 200;
res.setHeader('Content-Type', 'text/html');
fs.createReadStream(indexPath).pipe(res);

return;
}

if (req.method === 'GET' && pathname === '/add-expense') {
res.statusCode = 400;

return res.end('Only POST method allowed');
}

if (req.method === 'POST' && pathname === '/add-expense') {
let body = '';

req.on('data', (chunk) => {
body += chunk.toString();
});

req.on('end', () => {
let dataObj;

try {
const contentType = req.headers['content-type'];

if (contentType.includes('application/json')) {
dataObj = JSON.parse(body);
} else if (
contentType.includes('application/x-www-form-urlencoded')
) {
const parsed = new URLSearchParams(body);

dataObj = Object.fromEntries(parsed.entries());
} else {
res.writeHead(400, { 'Content-Type': 'text/plain' });

return res.end('Unsupported content type');
}

const { date, title, amount } = dataObj;

if (!date || !title || !amount) {
res.writeHead(400, { 'Content-Type': 'text/plain' });

return res.end('Invalid data format');
Comment on lines +56 to +59
Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor Aug 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code checks for presence of amount, but does not validate that it is numeric. The requirements specify that non-numeric amounts should be handled as invalid input. Consider adding a check like isNaN(Number(amount)) and returning a 400 error if the value is not numeric.

}

const filePath = path.resolve('db', 'expense.json');
Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor Aug 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You must ensure that the db directory exists before attempting to read or write expense.json. If the directory does not exist, file operations will fail. Add logic to check for and create the directory as needed before this point.


fs.readFile(filePath, (err, fileData) => {
let parsedFileData = [];

if (err) {
res.writeHead(500, { 'Content-Type': 'text/plain' });

return res.end(`Server error: ${err}`);
} else {
parsedFileData = JSON.parse(fileData);

if (typeof parsedFileData === 'object') {
if (Object.keys(parsedFileData).length) {
parsedFileData = [parsedFileData];
parsedFileData.push(dataObj);
} else if (!Object.keys(parsedFileData).length) {
parsedFileData = dataObj;
} else if (Array.isArray(parsedFileData)) {
parsedFileData.push(dataObj);
}
Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor Aug 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic for updating parsedFileData is convoluted and may not always result in an array of expenses. The requirements expect the file to contain the latest submitted expense data, and ideally, all expenses should be stored as an array. Simplify this logic to always append new expenses to an array.

}

const newData = JSON.stringify(parsedFileData, null, 2);

fs.writeFile(filePath, newData, (error) => {
if (error) {
res.writeHead(500, { 'Content-Type': 'text/plain' });

return res.end(`Server error: ${error}`);
}
res.writeHead(200, { 'Content-Type': 'application/json' });
res.end(newData);
Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor Aug 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After saving, the response is sent as application/json with the raw JSON data. The requirements specify that you must return an HTML page displaying the saved JSON in a well-formatted way (e.g., inside a <pre> tag) and set the content type to text/html. Update this section to generate an HTML response accordingly.

});
}
});
} catch (e) {
res.writeHead(400, { 'Content-Type': 'text/plain' });
res.end(`Invalid request body: ${e.message}`);
}
});
} else {
res.statusCode = 404;
res.end('Not found');
}
});

return server;
}

module.exports = {
Expand Down