add task solution#149
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Thanks for your work! There's a critical issue: the form's action is set to /submit, but your server only handles POST requests at /add-expense. This means form submissions won't be processed correctly. Please update the form's action attribute in src/index.html to /add-expense so it matches the server route. Once that's fixed, your app should work as expected! 🚀
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
| </head> | ||
| <body> | ||
| <h1>Add an Expense</h1> | ||
| <form action="/submit" method="POST" enctype="multipart/form-data"> |
There was a problem hiding this comment.
Issue: The form's action is set to '/submit', but your server expects POST requests at '/add-expense'.
To fix this, change the action attribute to '/add-expense' so the form submission matches the server route.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Great job! 🎉 Your implementation fully meets all the core requirements and constraints of the task. The form is correctly structured, the server handles submissions and data persistence as expected, and the response is formatted properly. No critical issues were found—keep up the good work!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
No description provided.