Skip to content

form-data #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yzhyhaliuk wants to merge 3 commits into
base: master
Choose a base branch
from
Open

form-data #146

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bf5f349
form-data
yzhyhaliuk May 2, 2025
2e726f8
run tests one more time
yzhyhaliuk May 2, 2025
e39e266
convert into a number
yzhyhaliuk May 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions .github/workflows/test.yml-template
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
name: Test

on:
pull_request:
branches: [ master ]

jobs:
build:

runs-on: ubuntu-latest

strategy:
matrix:
node-version: [20.x]

steps:
- uses: actions/checkout@v2
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node-version }}
- run: npm install
- run: npm test
4 changes: 2 additions & 2 deletions db/expense.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"amount": "100",
Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor May 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The value for 'amount' is a string ("100"). If the task requires 'amount' to be a number, you should remove the quotes so it becomes: 100. Please check the requirements or checklist for the correct type.

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor May 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'amount' field is currently stored as a string ("100"). According to the requirements, it should be stored as a number (e.g., 100 without quotes). Please update this value to be a number.

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor May 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'amount' field is currently stored as a string ("100"). According to the requirements, it should be stored as a number (100). Please remove the quotes around the value to ensure it is saved as a number.

"date": "2024-01-25",
"title": "Test Expense",
"amount": "100"
"title": "Test Expense"
}
9 changes: 5 additions & 4 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"license": "GPL-3.0",
"devDependencies": {
"@mate-academy/eslint-config": "latest",
"@mate-academy/scripts": "^1.8.6",
"@mate-academy/scripts": "^2.1.1",
"axios": "^1.7.2",
"eslint": "^8.57.0",
"eslint-plugin-jest": "^28.6.0",
Expand Down
78 changes: 76 additions & 2 deletions src/createServer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,82 @@
'use strict';

const http = require('http');
const path = require('path');
const fs = require('fs');

function createServer() {
/* Write your code here */
// Return instance of http.Server class
const server = new http.Server((req, res) => {
if (req.method === 'GET' && req.url === '/') {
const filePath = path.join(__dirname, 'index.html');

fs.readFile(filePath, (err, content) => {
if (err) {
res.writeHead(400);
res.end('Server error');

return;
}

res.setHeader('Content-Type', 'text/html');
res.end(content);
});

return;
}

if (req.method === 'POST' && req.url === '/add-expense') {
let body = '';

req.on('data', (chunk) => {
body += chunk.toString();
});

req.on('end', () => {
let fields;

try {
fields = JSON.parse(body);
} catch (err) {
res.statusCode = 400;

return res.end('Invalid JSON');
}

const expensePath = path.join(__dirname, '..', 'db', 'expense.json');

if (!fields.date || !fields.title || !fields.amount) {
res.statusCode = 400;

return res.end('Missing required fields');
}

const expense = {
amount: fields.amount,
Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor May 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'amount' field is saved directly from the request body (fields.amount). If the requirements specify that 'amount' should be a number, you should convert it to a number (e.g., using Number(fields.amount)) before saving. Otherwise, it will be saved as a string if the client sends it as such.

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor May 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'amount' field is being stored directly from the request body (fields.amount). According to the requirements, 'amount' must be stored as a number. Please convert 'fields.amount' to a number (e.g., using Number(fields.amount)) before saving it to the expense object.

date: fields.date,
title: fields.title,
};

fs.writeFile(expensePath, JSON.stringify(expense, null, 2), (err) => {
if (err) {
res.statusCode = 500;

return res.end('Failed to save');
}

res.writeHead(200, { 'Content-Type': 'application/json' });

res.end(JSON.stringify(expense));
});
});

return;
}

res.statusCode = 404;
res.end('Not found');
});

return server;
}

module.exports = {
Expand Down
26 changes: 26 additions & 0 deletions src/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>Form Data</title>
</head>
<body>
<h1>Your expenses:</h1>
<form method="POST" action="/add-expense">
<label>Enter date:
<input type="date" name="date" required />
</label>
<br><br>
<label>Enter title:
<input type="text" name="title" required />
</label>
<br><br>
<label>Enter amount:
<input type="number" name="amount" required />
</label>
<br><br>
<button type="submit">Submit</button>
</form>
</body>
</html>