-
Notifications
You must be signed in to change notification settings - Fork 305
add task solution #161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
YevychAndr
wants to merge
1
commit into
mate-academy:master
Choose a base branch
from
YevychAndr:develop
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
add task solution #161
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| <!DOCTYPE html> | ||
| <html lang="en"> | ||
| <head> | ||
| <meta charset="UTF-8"> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0"> | ||
| <title>File Compression App</title> | ||
| </head> | ||
| <body> | ||
| <h1>File Compression App</h1> | ||
| <form action="/compress" method="POST" enctype="multipart/form-data"> | ||
| <div> | ||
| <label for="file">Select a file to compress:</label> | ||
| <input type="file" id="file" name="file" required> | ||
| </div> | ||
| <div> | ||
| <label for="compressionType">Choose compression type:</label> | ||
| <select id="compressionType" name="compressionType" required> | ||
| <option value="gzip">Gzip (.gz)</option> | ||
| <option value="deflate">Deflate (.dfl)</option> | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Issue: The Deflate option displays the extension as '.dfl', but the server uses '.deflate' as the extension. If your task or checklist requires consistency between the UI and server-side file extensions, consider updating this to '.deflate'. |
||
| <option value="br">Brotli (.br)</option> | ||
| </select> | ||
| </div> | ||
| <div> | ||
| <button type="submit">Compress File</button> | ||
| </div> | ||
| </form> | ||
| </body> | ||
| </html> | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue: The filename in the Content-Disposition header is not wrapped in quotes. According to RFC 6266, if the filename contains spaces or special characters, it should be quoted. If your task or checklist requires strict compliance with RFC or handling of filenames with spaces, consider wrapping the filename in double quotes.