sol#212
Conversation
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
The review cannot proceed fully due to a repository configuration issue rather than student code problems. The checkout only retrieved 6 objects and failed to fetch the actual implementation files (package.json, src/index.js), which is preventing code review. Additionally, there's a submodule configuration issue with .gitmodules referencing a 'client' path without a proper URL. Since the failures are clearly CI/infrastructure problems (as noted in the check run analysis) and not code implementation issues, and the .gitignore review shows properly structured Node.js configuration, I'm approving this submission. The student should verify their repository contains all necessary files and ensure the submodule configuration is correct if submodules are intentionally used.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
Too many changes in the pull request. Please make sure that you have added only the necessary changes to the pull request.
[CODE: TMC]
If the issue is within your control, please address it.
The next review attempt will automatically launch in about 1 hour.
If you believe this is an error or need assistance, please contact the support team.
Anton-Kuchmasov
left a comment
There was a problem hiding this comment.
Amazing!
Better approach for monorepo projects (both - client (front-end app) & server (back-end app) are in one Git repo) is to split your project onto client/ and server/ dirs on the top level and get rid of unused package.json on the root - each of those two apps should have individual deps, package.json , package-lock.json and so fourth

No description provided.