Skip to content

Task#210

Open
Augustwise wants to merge 15 commits into
mate-academy:masterfrom
Augustwise:develop
Open

Task#210
Augustwise wants to merge 15 commits into
mate-academy:masterfrom
Augustwise:develop

Conversation

@Augustwise
Copy link
Copy Markdown

This app was built using a PostgreSQL database. An ER diagram (to help you understand the db structure) is attached below. The login and registration processes use a REST API, while WebSockets are used for everything else (creating rooms, renaming rooms, writing messages, and so on).

mate-node

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, the pull request review was unsuccessful for the following reasons:

Warning

Too many changes in the pull request. Please make sure that you have added only the necessary changes to the pull request.
[CODE: TMC]

If the issue is within your control, please address it.
The next review attempt will automatically launch in about 1 hour.
If you believe this is an error or need assistance, please contact the support team.

Copy link
Copy Markdown

@vitalii-bondarenko-ua vitalii-bondarenko-ua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

clients.forEach((client) => sendJson(client, message));
}

// we use this to broadcast messages to all clients in a specific room
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggest do not keep unnessary comments. code should be clean and understandable without comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants