add task solution by 4xmplme · Pull Request #507 · mate-academy/node_accounting-app-with-db

4xmplme · 2026-03-31T13:03:01Z

No description provided.

mateacademy-ai-mentor

Review Summary

I am requesting changes because the primary requirement of this task—implementing full CRUD functionality for categories—is missing from your submission. While the existing code for users and expenses is well-structured, the new feature has not been added.

To complete the task, you'll need to:

Create a new Category model.
Implement the corresponding service, controller, and router for categories.
Ensure the new routes are registered in src/createServer.js.
Add the new Category model to the database synchronization script in src/setup.js.

Please implement these missing pieces to manage categories as required by the task description.

✨ Please rate this review in the Platform's notification center¹. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button² in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag³.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

mateacademy-ai-mentor · 2026-03-31T13:04:58Z

+
+  app.use(express.json());
+  app.use('/users', routes.usersRouter);
+  app.use('/expenses', routes.expensesRouter);


The new routes for managing categories are missing. Based on the task requirements, you should add a new router here for the /categories endpoint.

mateacademy-ai-mentor · 2026-03-31T13:04:58Z

+module.exports = {
+  usersController,
+  expensesController,
+};


The task requires implementing CRUD operations for categories. This would involve creating a categoriesController, which should be imported and exported from this file.

mateacademy-ai-mentor · 2026-03-31T13:04:58Z

+module.exports = {
+  usersService,
+  expensesService,
+};


The task is to add CRUD functionality for categories. This would require a new categories.service.js file. Once created, the categoriesService should be imported and exported from this index file.

mateacademy-ai-mentor · 2026-03-31T13:04:58Z

+exports.routes = {
+  usersRouter,
+  expensesRouter,
+};


According to the task requirements, you need to implement CRUD for categories. This file should import the categoriesRouter from its corresponding route file and include it in the exported routes object.

mateacademy-ai-mentor · 2026-03-31T13:04:58Z

+const { User, Expense } = require('./models');
+
+User.sync({ force: true });
+Expense.sync({ force: true });


The new Category model, which is a core part of the task, is not being synchronized with the database here. You need to import the Category model and add a Category.sync({ force: true }) call.

mateacademy-ai-mentor

Review Summary

The category CRUD implementation is incomplete because the routes are not registered in the server, which is a critical blocker preventing the feature from working. Specifically, src/routes/index.js does not export categoriesRouter, so it cannot be imported and used in src/createServer.js. Additionally, src/createServer.js is missing the required route registration: app.use('/categories', routes.categoriesRouter);. Without these two changes, the /categories endpoints will be completely inaccessible, violating the core task requirement to ensure new routes are registered in src/createServer.js. Other integration gaps — like missing exports for categoriesController in src/controllers/index.js and categoriesService in src/services/index.js — also reduce consistency and maintainability. Please add the missing exports and route registration to complete the integration.

✨ Please rate this review in the Platform's notification center¹. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button² in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag³.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

mateacademy-ai-mentor · 2026-03-31T13:30:54Z

+    return res.sendStatus(400);
+  }
+
+  const category = await categoriesService.create(name);


The categories router is not registered in the server. The task requires ensuring new routes are registered in createServer.js.

mateacademy-ai-mentor · 2026-03-31T13:30:54Z

+const { categoriesService } = require('../services/categories.service');
+
+const create = async (req, res) => {
+  const { name } = req.body;


The categories router is missing from exports. Need to export categoriesRouter here so it can be used in createServer.js.

mateacademy-ai-mentor · 2026-03-31T13:30:55Z

+const { usersService } = require('../services/users.service');
+
+const create = async (req, res) => {
+  const { name } = req.body;
+
+  if (!name) {


The categoriesController is not exported in the controllers index file - other parts of the app cannot import it

mateacademy-ai-mentor · 2026-03-31T13:30:55Z

+const { usersService } = require('../services/users.service');
+
+const create = async (req, res) => {
+  const { name } = req.body;
+
+  if (!name) {
+    return res.sendStatus(400);


Need to add categoriesController export here to make it available to routes

mateacademy-ai-mentor · 2026-03-31T13:30:55Z

+  const { userId, spentAt, title, amount, category, note } = req.body;
+  const user = await usersService.getOne(userId);
+
+  if (!userId || !user) {
+    return res.sendStatus(400);


src/routes/index.js is missing export for categoriesRouter

mateacademy-ai-mentor · 2026-03-31T13:30:55Z

+  }
+
+  const expense = await expensesService.create({


src/createServer.js is missing route registration for categoriesRouter

mateacademy-ai-mentor · 2026-03-31T13:30:55Z

+  const user = await usersService.getOne(userId);
+
+  if (!userId || !user) {


src/services/index.js is missing export for categoriesService

mateacademy-ai-mentor · 2026-03-31T13:30:55Z

+  const user = await usersService.getOne(userId);
+
+  if (!userId || !user) {


src/controllers/index.js is missing export for categoriesController

mateacademy-ai-mentor · 2026-03-31T13:30:55Z

+
+module.exports = {
+  usersController,
+  expensesController,


The categoriesRouter is not exported from src/routes/index.js. Only usersRouter and expensesRouter are exported, but categoriesRouter needs to be added to make it available for registration.

mateacademy-ai-mentor · 2026-03-31T13:30:55Z

+module.exports = {
+  usersController,
+  expensesController,
+};


The categoriesController is not imported or exported from src/controllers/index.js. Without exporting it, other parts of the application cannot access the category controller.

mateacademy-ai-mentor · 2026-03-31T13:30:59Z

+const { expensesController } = require('./expenses.controller');
+
+module.exports = {
+  usersController,


The categoriesService is not exported from src/services/index.js. Without exporting it, the controller cannot access the category service methods.

mateacademy-ai-mentor · 2026-03-31T13:30:59Z

+    type: DataTypes.INTEGER,
+    allowNull: false,
+  },
+  title: {


The categories router is not registered in the server. The task explicitly requires: 'Ensure the new routes are registered in src/createServer.js'. Add: app.use('/categories', routes.categoriesRouter);

mateacademy-ai-mentor · 2026-03-31T13:30:59Z

+  app.use('/users', routes.usersRouter);
+  app.use('/expenses', routes.expensesRouter);


The categories router is NOT registered in the server. The task requires: 'Ensure the new routes are registered in src/createServer.js'. Currently only /users and /expenses are registered. Need to add: app.use('/categories', routes.categoriesRouter); after line 10.

mateacademy-ai-mentor · 2026-03-31T13:30:59Z

+const { Router } = require('express');
+const { expensesController } = require('./../controllers/expenses.controller');
+
+const expensesRouter = Router();
+
+expensesRouter.post('/', expensesController.create);


The categories router is not imported and exported. Need to add: const { categoriesRouter } = require('./categories.route'); and add categoriesRouter to the exports object.

mateacademy-ai-mentor · 2026-03-31T13:30:59Z

 'use strict';

-const { sequelize } = require('../db.js');
+const { sequelize } = require('../db');
+const { DataTypes } = require('sequelize');

-const User = sequelize.define(
-  // your code goes here
-);
+const User = sequelize.define('User', {


The categoriesRouter is NOT exported from src/routes/index.js. Currently only usersRouter and expensesRouter are exported. Need to add: const { categoriesRouter } = require('./categories.route'); and add categoriesRouter to the exports object.

mateacademy-ai-mentor · 2026-03-31T13:30:59Z

+const { usersRouter } = require('./users.route');
+const { expensesRouter } = require('./expenses.route');
+
+exports.routes = {
+  usersRouter,
+  expensesRouter,


The categories router is not exported from src/routes/index.js. Currently only usersRouter and expensesRouter are exported. Need to add: const { categoriesRouter } = require('./categories.route'); and include it in exports.

mateacademy-ai-mentor · 2026-03-31T13:30:59Z

+
+exports.routes = {
+  usersRouter,
+  expensesRouter,


Need to export categoriesRouter in the routes object to make it available for registration in createServer.js.

mateacademy-ai-mentor · 2026-03-31T13:30:59Z

+const { Router } = require('express');
+const {
+  categoriesController,
+} = require('./../controllers/categories.controller');
+
+const categoriesRouter = Router();


The categoriesRouter is NOT exported. Need to import it and add it to exports: const { categoriesRouter } = require('./categories.route'); and add categoriesRouter to the exports object. Without this, the categories route cannot be used in createServer.js

mateacademy-ai-mentor · 2026-03-31T13:30:59Z

+const { Category } = require('../models');
+
+const normalize = ({ id, name }) => ({ id, name });
+
+const create = async (name) => {
+  const category = await Category.create({ name });


The categoriesRouter is NOT exported. Need to import it and add to exports: const { categoriesRouter } = require('./categories.route'); and add categoriesRouter to the exports object.

mateacademy-ai-mentor · 2026-03-31T13:30:59Z

+const { Router } = require('express');
+const { usersController } = require('./../controllers/users.controller');
+
+const usersRouter = Router();
+
+usersRouter.post('/', usersController.create);


The categoriesService is NOT exported from src/services/index.js. Currently only usersService and expensesService are exported. Need to add: const { categoriesService } = require('./categories.service'); and include it in the exports.

mateacademy-ai-mentor · 2026-03-31T13:31:04Z

+const { usersService } = require('./users.service');
+const { expensesService } = require('./expenses.service');
+
+module.exports = {
+  usersService,
+  expensesService,


The categoriesService is not exported from src/services/index.js. Need to add: const { categoriesService } = require('./categories.service'); and include it in the exports.

… index files and fix imports paths

mateacademy-ai-mentor

Review Summary

I am approving your solution as an educational override to help you move forward, but please take a moment to review the feedback below.

Excellent work addressing all the integration issues from the previous review! The category CRUD functionality is now fully implemented and works well.

There's one small improvement to consider in src/controllers/categories.controller.js. The update function is missing validation for the request body. If a client tries to update a category without providing a name, it could cause an issue. It's a good practice to add a check to ensure req.body.name is present before proceeding, just like you did in the create function.

This is a minor point in an otherwise excellent submission. Keep up the great work!

✨ Please rate this review in the Platform's notification center¹. I will be grateful for your feedback! ✨

Rate AI review example ↩

mateacademy-ai-mentor · 2026-03-31T13:51:36Z

+  res.send(categoriesService.normalize(category));
+};
+
+const update = async (req, res) => {


It's a good practice to validate the request body here, similar to how you've done it in the create function. What would happen if a client sends a request to update a category without providing a name? Consider adding a check to ensure req.body.name is present and returning a 400 Bad Request if it's not.

add task solution

67d06ff

mateacademy-ai-mentor suggested changes Mar 31, 2026

View reviewed changes

implement CRUD page to manage categories

e2fecea

4xmplme requested a review from mateacademy-ai-mentor March 31, 2026 13:28

mateacademy-ai-mentor suggested changes Mar 31, 2026

View reviewed changes

mateacademy-ai-mentor reviewed Mar 31, 2026

View reviewed changes

4xmplme added 2 commits March 31, 2026 16:36

add categoriesRouter to routes and use it in createServer function

d2f753c

add exports of categories.services/controllers/route to corresponding…

328786b

… index files and fix imports paths

4xmplme requested a review from mateacademy-ai-mentor March 31, 2026 13:48

mateacademy-ai-mentor approved these changes Mar 31, 2026

View reviewed changes

improve params check in controllers

34d078c

4xmplme requested a review from mateacademy-ai-mentor March 31, 2026 14:23

		const user = await usersService.getOne(userId);

		if (!userId \|\| !user) {

		app.use('/users', routes.usersRouter);
		app.use('/expenses', routes.expensesRouter);

Conversation

4xmplme commented Mar 31, 2026

Uh oh!

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

Review Summary

Footnotes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

Review Summary

Footnotes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

Review Summary

Footnotes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants