Develop

[ArkadiuszBalakier]

https://ArkadiuszBalakier.github.io/layout_miami/

[natalia-klonowska]

demo link doesn’t work. deploy project using npm run deploy command

[ArkadiuszBalakier]

sorry, project deployed. I didn't noticed that this task is reviewed not by AI :)

[natalia-klonowska]

• burger menu icon doesn't appear

• close icon touches the screen edge instead of being spaced with padding

• disable page scrolling under the menu and ensure that no elements are on the same level as menu as they will be visible during section navigation

CHECKLIST:

• Add a favicon
• All Logos on the page should be links to home page
• Change text color on hover for phone, email and address
• When clicking on any location / address - prevent errors and make it to open location in Google Maps
• Pictures in Gallery should increase on hover
• Page shouldn't be reloaded on form submit
• disable page scrolling under the menu

[natalia-klonowska]

use full image with better quality

[natalia-klonowska]

• scrollbar is still visible

CHECKLIST:

• Add a favicon
• All Logos on the page should be links to home page
• Change text color on hover for phone, email and address
• When clicking on any location / address - prevent errors and make it to open location in Google Maps
• Pictures in Gallery should increase on hover
• Page shouldn't be reloaded on form submit
• disable page scrolling under the menu

[natalia-klonowska]

• you still need to add favicon and prevent form from reloading the page on submit
• between tablet and desktop versions images from recommended section scale up so much that their quality becomes poor. also you need to add space between images and their titles

• on tablet and desktop versions paragraph has extra padding causing misalignment. also this section and contact section have side padding of 76px instead of the intended 120px

[natalia-klonowska]

Great work! just a few final fixes:

• add success message and/or clear inputs to indicate that form was submitted successfully
• section title should have the same max width as the rest of section

[natalia-klonowska]

“Message sent successfully!” appears even when all form inputs are empty so there's no validation for form fields

[ArkadiuszBalakier]

“Message sent successfully!” appears even when all form inputs are empty so there's no validation for form fields

can we use JS ?

[natalia-klonowska]

tak możesz używać js a nawet już to robisz wykorzystując event.preventDefault() ;) po prostu zamiast umieszczać logikę bezpośrednio w atrybucie onsubmit to wykorzystaj już podlinkowany w html plik main.js
zobacz sobie przykład użycia: https://developer.mozilla.org/en-US/docs/Web/API/Event/preventDefault
oczywiście musisz to dostosować do swojego przypadku. najpierw używasz np. querySelectora do wybrania formularza a następnie dodajesz do niego addEventListener dla zdarzenia submit. To właśnie tam w funkcji używasz event.preventDefault() i np. reset() aby było widać że submit się udał

[natalia-klonowska]

na deployu z jakiegoś powodu nie ładuje ci się plik js bo jest zła ścieżka ale masz ją ustawioną poprawnie więc spróbuj wykonać ponownie deploy