BOSE page#2721
Open
wojthecode wants to merge 56 commits intomate-academy:developfrom
Open
Conversation
update checklist to be more generic
…-figma-link [Miami]: changed MyBike Figma link to a new version
update dependencies
Feature/prettier
add latest deps
Update package.json
natalia-klonowska
suggested changes
Dec 4, 2025
natalia-klonowska
left a comment
natalia-klonowska
left a comment
There was a problem hiding this comment.
deploy your project using npm run deploy command and add demo link to pr description
natalia-klonowska
suggested changes
Dec 5, 2025
natalia-klonowska
left a comment
natalia-klonowska
left a comment
There was a problem hiding this comment.
- Change text color on hover for phone, email and address
- When clicking on any location / address - prevent errors and make it to open location in Google Maps
- Pictures in Gallery should increase on hover
- Form shouldn't be submitted if some of the fields are not filled
- Page shouldn't be reloaded on form submit
- disable page scrolling under the menu
… hover, disabled scrolling under menu
natalia-klonowska
suggested changes
Dec 18, 2025
natalia-klonowska
left a comment
natalia-klonowska
left a comment
There was a problem hiding this comment.
- contact section next to form should start at the same height and submitting form shouldn’t reload the page instead you can add success message and clear inputs
- phone icon is too large on mobile version and icon in the title should be positioned higher with more spacing from title
…ction and tittle icon
natalia-klonowska
suggested changes
Dec 22, 2025
natalia-klonowska
left a comment
natalia-klonowska
left a comment
There was a problem hiding this comment.
using action="#" and fetch("#") may work on localhost but in deployed version it causes page reload
| <section class="main__section main__section--contact" id="contact"> | ||
| <h2 class="title title__main title__main--contact">Contact us</h2> | ||
|
|
||
| <form action="#" class="contact"> |
There was a problem hiding this comment.
Suggested change
| <form action="#" class="contact"> | |
| <form class="contact"> |
Comment on lines
+7
to
+12
| const formData = new FormData(contactForm); | ||
|
|
||
| fetch("#", { // <- server address | ||
| method: "POST", | ||
| body: formData | ||
| }) |
There was a problem hiding this comment.
Suggested change
| const formData = new FormData(contactForm); | |
| fetch("#", { // <- server address | |
| method: "POST", | |
| body: formData | |
| }) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wojthecode.github.io/layout_miami/