Skip to content

added task solution#790

Open
LabPetro wants to merge 3 commits into
mate-academy:masterfrom
LabPetro:develop
Open

added task solution#790
LabPetro wants to merge 3 commits into
mate-academy:masterfrom
LabPetro:develop

Conversation

@LabPetro
Copy link
Copy Markdown

Comment thread src/style.css Outdated
@@ -1 +1,12 @@
/* styles go here */
.duo {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use a more descriptive class name instead of 'duo'. For example, 'form-group'.

Comment thread src/style.css Outdated
margin-bottom: 20px;
}

.quads {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use a more descriptive class name instead of 'quads'. For example, 'form-block'.

Comment thread src/index.html Outdated
id="review"
name="rating"
step="1"
max="0"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The max attribute of the 'review' input should be greater than the min attribute. It doesn't work
image

Comment thread src/index.html Outdated
class="duo"
type="text"
id="surname"
name="info"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name attribute should be more descriptive, e.g. 'surname' instead of 'info'.

Comment thread src/index.html Outdated
class="duo"
type="text"
id="name"
name="information"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name attribute should be more descriptive, e.g. 'name' instead of 'information'.

Comment thread src/index.html Outdated
Comment on lines +22 to +27
<input
class="duo"
type="text"
id="surname"
name="info"
autocomplete="off"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the code style everywhere

Suggested change
<input
class="duo"
type="text"
id="surname"
name="info"
autocomplete="off"
<input
class="duo"
type="text"
id="surname"
name="info"
autocomplete="off"

Comment thread src/index.html Outdated

<div class="duo">
<label for="cat">Do you love cats?</label>
<input
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a label to each radio button. It doesn't work correctly now

Screen.Recording.2023-05-17.at.13.49.21.mov

Comment thread src/index.html
Comment on lines +150 to +152
</div>

</fieldset>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
</div>
</fieldset>
</div>
</fieldset>

Comment thread src/index.html Outdated
Comment on lines +187 to +189
<button
type="submit"
>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<button
type="submit"
>
<button type="submit">

Comment thread src/style.css Outdated
margin-bottom: 10px;
}

fieldset {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use classes for styling

Comment thread src/index.html Outdated
Comment on lines +96 to +109
<label for="yes">Yes</label>
<input
id="yes"
type="radio"
name="pet"
value="yes"
>
<label for="no">No</label>
<input
id="no"
type="radio"
name="pet"
value="No"
>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<label for="yes">Yes</label>
<input
id="yes"
type="radio"
name="pet"
value="yes"
>
<label for="no">No</label>
<input
id="no"
type="radio"
name="pet"
value="No"
>
<label>
<input
id="yes"
type="radio"
name="pet"
value="yes"
>
Yes
</label>
<label>
<input
id="no"
type="radio"
name="pet"
value="No"
>
No
</label>

You can wrap it into label tag to fix previous comment

Comment thread src/index.html Outdated
Comment on lines +146 to +153
<input type="range"
id="review"
name="rating"
step="1"
value="0"
min="0"
max="5"
>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<input type="range"
id="review"
name="rating"
step="1"
value="0"
min="0"
max="5"
>
<input
type="range"
id="review"
name="rating"
step="1"
value="0"
min="0"
max="5"
>

Comment thread src/index.html Outdated
Comment on lines +163 to +167
<textarea name="write"
id="comments"
autocomplete="off"
required
></textarea>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<textarea name="write"
id="comments"
autocomplete="off"
required
></textarea>
<textarea
name="write"
id="comments"
autocomplete="off"
required
></textarea>

Comment thread src/index.html Outdated
Comment on lines +176 to +177
<option value="answer">Yes</option>
<option value="answer">No</option>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<option value="answer">Yes</option>
<option value="answer">No</option>
<option value="yes">Yes</option>
<option value="no">No</option>

@LabPetro LabPetro requested a review from agniya-i May 18, 2023 22:55
Comment thread src/index.html
Comment on lines +15 to +17
<form
action="https://mate-academy-form-lesson.herokuapp.com/create-application"
method="post">
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<form
action="https://mate-academy-form-lesson.herokuapp.com/create-application"
method="post">
<form
action="https://mate-academy-form-lesson.herokuapp.com/create-application"
method="post"
>

Comment thread src/index.html
Comment on lines +18 to +19

<fieldset class="container">
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't add spaces between parent and child components

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants