add task solution #786
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| # HTML form | ||
| Replace `<your_account>` with your Github username and copy the links to Pull Request description: | ||
| - [DEMO LINK](https://KarolinaWiktoria.github.io/layout_html-form/) | ||
| - [TEST REPORT LINK](https://KarolinaWiktoria.github.io/layout_html-form/report/html_report/) | ||
|
|
||
| > Follow [this instructions](https://mate-academy.github.io/layout_task-guideline/#how-to-solve-the-layout-tasks-on-github) | ||
| ___ | ||
|
|
@@ -40,7 +40,7 @@ Create HTML page with form. On form submit send form data to `https://mate-acade | |
| - Age should be at least `1` and at max `100` with a default value of `12` | ||
| - The email field should have placeholder value: `[email protected]`. | ||
| - Text fields should have `autocomplete="off"`. | ||
| - `Submit` button should have a `type="submit"` | ||
| - Vertical distance between inputs should be `10px` | ||
| - Vertical distance between groups should be `20px` | ||
| - Any other styles should be browser default | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,17 +1,157 @@ | ||
|
|
||
| <!DOCTYPE html> | ||
| <html lang="en"> | ||
| <head> | ||
| <meta charset="UTF-8"> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0"> | ||
| <meta http-equiv="X-UA-Compatible" content="ie=edge"> | ||
| <title>The form</title> | ||
| <link rel="stylesheet" href="style.css"> | ||
| </head> | ||
| <body> | ||
| <form | ||
| method="POST" | ||
| action="https://mate-academy-form-lesson.herokuapp.com/create-application" | ||
| > | ||
| <fieldset class="inputs-block"> | ||
| <legend>Personal information</legend> | ||
|
|
||
| <label class="input-row"> | ||
| Surname: | ||
| <input name="surname" autocomplete="off"> | ||
|
There was a problem hiding this comment. Task requirements specify that you should use types attributes, even though inputs by default are type='text' mark it like so explicitly There was a problem hiding this comment. Also you forgot about some of these attributes: |
||
| </label> | ||
|
|
||
| <label class="input-row"> | ||
| Name: | ||
| <input name="name" autocomplete="off"> | ||
| </label> | ||
|
|
||
| <label class="input-row"> | ||
| How old are You? | ||
| <input | ||
| type="number" | ||
| name="age" | ||
| min="1" | ||
| max="100" | ||
| value="12" | ||
| > | ||
| </label> | ||
|
|
||
| <label class="input-row"> | ||
| Full date of birth: | ||
| <input type="date" name="birthday"> | ||
| </label> | ||
|
|
||
| <label class="input-row"> | ||
| I accept the term of the agreement | ||
| <input type="checkbox" name="agreement"> | ||
| </label> | ||
| </fieldset> | ||
|
|
||
| <fieldset class="inputs-block"> | ||
| <legend>Registration</legend> | ||
|
|
||
| <label class="input-row"> | ||
| E-mail: | ||
| <input | ||
| type="email" | ||
| name="email" | ||
| placeholder="[email protected]" | ||
| > | ||
| </label> | ||
|
|
||
| <label class="input-row"> | ||
| Password: | ||
| <input | ||
| type="password" | ||
| name="password" | ||
| > | ||
| </label> | ||
| </fieldset> | ||
|
|
||
| <fieldset class="inputs-block"> | ||
| <legend>An interesting fact about you!</legend> | ||
|
|
||
| <div class="input-row"> | ||
| Do you love cats? | ||
|
|
||
| <label> | ||
| <input | ||
| type="radio" | ||
| name="cats" | ||
| value="yes" | ||
| > | ||
| Yes | ||
| </label> | ||
|
|
||
| <label> | ||
|
There was a problem hiding this comment. Fix the indent: <label>
<input
type="radio"
name="cats"
value="no"
>
No
</label> |
||
| <input | ||
| type="radio" | ||
| name="cats" | ||
| value="no" | ||
| > No | ||
| </label> | ||
| </div> | ||
|
|
||
| <label class="input-row"> | ||
| What is your favorite color? | ||
| <input type="color" name="color"> | ||
| </label> | ||
|
|
||
| <label class="input-row"> | ||
| What time do you go to bed? | ||
| <input | ||
| type="time" | ||
| name="time" | ||
| step="1" | ||
| > | ||
| </label> | ||
|
|
||
| <label class="input-row"> | ||
| What are your favorite brand of cars? | ||
|
|
||
| <select multiple name="cars"> | ||
| <option value="bmw">BMW</option> | ||
| <option value="audi">Audi</option> | ||
| <option value="lada">Lada</option> | ||
| </select> | ||
| </label> | ||
|
|
||
| <label class="input-row"> | ||
| How do you rate our work? | ||
|
|
||
| <input | ||
| type="range" | ||
| name="rate" | ||
| min="0" | ||
| max="5" | ||
| step="1" | ||
| value="0" | ||
| > | ||
| </label> | ||
| </fieldset> | ||
|
|
||
| <fieldset class="inputs-block"> | ||
| <legend>Additional info:</legend> | ||
|
|
||
| <label class="input-row"> | ||
| Comments: | ||
| <textarea name="comments"></textarea> | ||
| </label> | ||
|
|
||
| <label class="input-row"> | ||
| Would you recommend us? | ||
|
|
||
| <select name="recommend"> | ||
| <option value="yes">yes</option> | ||
| <option value="no">no</option> | ||
| </select> | ||
| </label> | ||
| </fieldset> | ||
|
|
||
| <button type="submit"> | ||
| Submit | ||
| </button> | ||
| </form> | ||
| </body> | ||
| </html> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,8 @@ | ||
| .input-row:not(:last-child) { | ||
| display: block; | ||
| margin-bottom: 10px; | ||
| } | ||
|
|
||
| .inputs-block:not(:last-child) { | ||
| margin-bottom: 20px; | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This way of wrapping with label is kinda unorthodox, I'd suggest in the future do it the "regular way" without wrapping and using 'for' and 'id' attributes for the sake of readability,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now just add an empty line between all label titles and inputs e.g.:
Do it for all your labels with inputs