add Form#780
Open
RendyDm wants to merge 1 commit into
Open
Conversation
RendyDm
commented
Apr 25, 2023
RendyDm
commented
- DEMO LINK
- TEST REPORT LINK
etojeDenys
suggested changes
Apr 26, 2023
| <label class="form-field"> | ||
| Surname: | ||
| <input | ||
| type="name" |
There was a problem hiding this comment.
Change the input type from 'name' to 'text' for the Surname field 🧐
|
|
||
| <label class="form-field">Password: | ||
| <input | ||
| type="Password" |
There was a problem hiding this comment.
Change the input type from 'Password' to 'password' for the Password field 🔒
| <label class="form-field"> | ||
| Name: | ||
| <input | ||
| type="name" |
There was a problem hiding this comment.
Change the input type from 'name' to 'text' for the Name field 🧐
| <label class="form-field"> | ||
| Full data of birth: | ||
| <input | ||
| type="data" |
There was a problem hiding this comment.
Change the input type from 'data' to 'date' for the Full data of birth field 📅
Comment on lines
+26
to
+35
| <input | ||
| type="name" | ||
| name="surname" | ||
| minlength="5" | ||
| maxlength="12" | ||
| required | ||
| tabindex="1" | ||
| > | ||
| </label> | ||
|
|
Comment on lines
+109
to
+120
| <div class="form-field"> | ||
| <label>Do you love cats? | ||
| <input | ||
| type="radio" | ||
| name="question" | ||
| >Yes | ||
| <input | ||
| type="radio" | ||
| name="question" | ||
| >No | ||
| </label> | ||
| </div> |
There was a problem hiding this comment.
cover each input in a separate label to avoid this behavior
Screen.Recording.2023-04-26.at.09.46.21.mov
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.