Develop#777
Open
JeniaAndruhsko wants to merge 4 commits intomate-academy:masterfrom
Open
Conversation
Viktor-Kost
suggested changes
Apr 25, 2023
| method="POST" | ||
| action="https://mate-academy-form-lesson.herokuapp.com/create-application" | ||
| > | ||
| <fieldset class="fs1"> |
There was a problem hiding this comment.
use required for one of your inputs
Comment on lines
+17
to
+26
| <label class="label"> | ||
| Surname: | ||
| <input | ||
| type="text" | ||
| name="surname" | ||
| minlength="3" | ||
| maxlength="20" | ||
| autocomplete="off" | ||
| > | ||
| </label> |
There was a problem hiding this comment.
follow code styling recommendations
Suggested change
| <label class="label"> | |
| Surname: | |
| <input | |
| type="text" | |
| name="surname" | |
| minlength="3" | |
| maxlength="20" | |
| autocomplete="off" | |
| > | |
| </label> | |
| <label class="label"> | |
| Surname: | |
| <input | |
| type="text" | |
| name="surname" | |
| minlength="3" | |
| maxlength="20" | |
| autocomplete="off" | |
| > | |
| </label> |
Comment on lines
+36
to
+37
| </label> | ||
| <label class="label"> |
There was a problem hiding this comment.
add an empty line between multiline siblings
Suggested change
| </label> | |
| <label class="label"> | |
| </label> | |
| <label class="label"> |
Comment on lines
+84
to
+87
| <label class="label"> | ||
| Do you love cats? | ||
| <input | ||
| type="radio" |
There was a problem hiding this comment.
each label/select should be wrapped with a label
Suggested change
| <label class="label"> | |
| Do you love cats? | |
| <input | |
| type="radio" | |
| <div class="label"> | |
| Do you love cats? | |
| <label> | |
| <input | |
| type="radio" |
| </label> | ||
| </fieldset> | ||
|
|
||
| <fieldset class="fs1"> |
There was a problem hiding this comment.
redundant class
Suggested change
| <fieldset class="fs1"> | |
| <fieldset> |
| <label class="fs1"> | ||
| Would you recommend us? | ||
| <select | ||
| name="yes_or_no" |
There was a problem hiding this comment.
Suggested change
| name="yes_or_no" | |
| name="recommendation" |
| @@ -1 +1,13 @@ | |||
| /* styles go here */ | |||
| .label { | |||
There was a problem hiding this comment.
You may only apply those classes to your filedset and form field (label or div)
Example:
.fieldset:not(:last-child) {
margin-bottom: 20px
}
.field:not(:last-child) {
margin-bottom: 10px
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DEMO LINK
TEST REPORT LINK