Skip to content

first-check#1184

Open
notbelievable wants to merge 14 commits into
mate-academy:masterfrom
notbelievable:develop
Open

first-check#1184
notbelievable wants to merge 14 commits into
mate-academy:masterfrom
notbelievable:develop

Conversation

@notbelievable
Copy link
Copy Markdown

Copy link
Copy Markdown

@Denys-Kravchuk9988 Denys-Kravchuk9988 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

A few things to improve:

  1. I would recommend to add cursor: pointer for all block because by hover outside the image there is also scaling
Image
  1. This animation seems to be broken. By hover on this section there are lags
Image
  1. It's better to add cursor: pointer by hover this text
Image
  1. It's needed to remove autofill styles
Image

Copy link
Copy Markdown

@Anton-Kuchmasov Anton-Kuchmasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, but there are a few issues need to be fixed:

  1. Fix typo mistake: there should be leaRn more:
Image
  1. Also, please slightly reduce hover effect to avoid cards overlapping

  2. On mobile view, aside menu is not working :(

Image

Copy link
Copy Markdown

@brespect brespect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants