Skip to content

add task solution#1181

Open
NeustrVk wants to merge 6 commits into
mate-academy:masterfrom
NeustrVk:develop
Open

add task solution#1181
NeustrVk wants to merge 6 commits into
mate-academy:masterfrom
NeustrVk:develop

Conversation

@NeustrVk
Copy link
Copy Markdown

Copy link
Copy Markdown

@Anton-Kuchmasov Anton-Kuchmasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job you did!

To improve:

  1. Please reset all CSS Autofill styles in your form (if User enter some value from prefilled values, there should be no side-effects like background-color or other changes):
Image
  1. Navlink (header -> nav) Contact Us doesn't redirect user to chosen section (other links works correctly)

@NeustrVk NeustrVk requested a review from Anton-Kuchmasov May 10, 2026 19:56
Copy link
Copy Markdown

@brespect brespect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good progress, check next:

  1. Where is the slider on Desktop screen?
Image
  1. Slider buttons seem not working om Mobile view:
Image
  1. The form should not jump to top after submit:
Image
  1. Side menu looks broken on Mobile screen:
Image

@NeustrVk
Copy link
Copy Markdown
Author

NeustrVk commented May 12, 2026

@NeustrVk
Copy link
Copy Markdown
Author

NeustrVk commented May 12, 2026

@brespect

May I ask you to explain this little bit more
"4) Side menu looks broken on Mobile screen:"

What exactly you don't like in Side Menu on Mobile screen? Just couldn't understand from PrintScrin.. I'm checking on local server and it works normally for me.
It's about design or functionality?

Thank you.

@NeustrVk NeustrVk requested a review from brespect May 12, 2026 20:08
Copy link
Copy Markdown

@brespect brespect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, about 3 point - I expect to smoothly scrolls to top after submit, about 4 - it should look consistent with the design and be full screen width without scrolling. If you gave any questions feel free to ask in fe_chat

@NeustrVk NeustrVk requested a review from brespect May 13, 2026 21:09
Copy link
Copy Markdown

@brespect brespect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost done, but it should be no horizontal scroll on mobile screen:
Image

@NeustrVk NeustrVk requested a review from brespect May 14, 2026 09:07
Copy link
Copy Markdown

@brespect brespect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants