solution#1174
Open
AngelaStrechen wants to merge 4 commits intomate-academy:masterfrom
Open
Conversation
Denys-Kravchuk9988
suggested changes
Apr 24, 2026
Denys-Kravchuk9988
left a comment
Denys-Kravchuk9988
left a comment
There was a problem hiding this comment.
Good job!
A few things to improve:
- I would recommend to remove autofill
- It's better to disable scrolling when menu is open
- On tablet the page looks broken.
2pasha
suggested changes
Apr 30, 2026
2pasha
left a comment
2pasha
left a comment
There was a problem hiding this comment.
comments from previous review is still actual, make sure that you have redeployed your app
also some more things to improve:
- add favicon
- i would recommend to remove
box-shadowvalue on hover
2pasha
suggested changes
May 2, 2026
2pasha
left a comment
2pasha
left a comment
There was a problem hiding this comment.
good progress ! 👏
here are last improvements:
- disable page scrolling when menu is opened. try this approach
- when user click on nav items - page should be scrolled smoothly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DEMO LINK