Skip to content

add task solution#1172

Open
vitamartsekhovska wants to merge 2 commits into
mate-academy:masterfrom
vitamartsekhovska:develop
Open

add task solution#1172
vitamartsekhovska wants to merge 2 commits into
mate-academy:masterfrom
vitamartsekhovska:develop

Conversation

@vitamartsekhovska
Copy link
Copy Markdown

Copy link
Copy Markdown

@vitalii-bondarenko-ua vitalii-bondarenko-ua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job.

  • All form fields should be required and have correct types (email, tel, etc.)
  • Placeholders should give examples of what should be added, to make the expected format clear
  • The page shouldn't be reloaded on form submit, but the fields should be cleared. Use:
    <form onsubmit="this.reset(); return false;">. Actually now nothign happens on click to send button - for fix it button should be inside form tag.
Image

Copy link
Copy Markdown

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants