Skip to content

design for 1600px#1166

Open
KolodnytskaV wants to merge 18 commits into
mate-academy:masterfrom
KolodnytskaV:develop
Open

design for 1600px#1166
KolodnytskaV wants to merge 18 commits into
mate-academy:masterfrom
KolodnytskaV:develop

Conversation

@KolodnytskaV
Copy link
Copy Markdown

I finished design for 1600px but I have some problems with @media and import in main.css

Copy link
Copy Markdown

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you have any issues, feel free to ask for help in the chat, because it's hard to communicate here

@KolodnytskaV KolodnytskaV requested a review from etojeDenys March 30, 2026 16:02
Copy link
Copy Markdown

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

demo link does not work. please fix it and re-request the review

@KolodnytskaV KolodnytskaV requested a review from etojeDenys March 31, 2026 09:24
Copy link
Copy Markdown

@vadiimvooo vadiimvooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still no demo link in the description of PR and deploy. Please feel free to ask for help in fe_chat.

@KolodnytskaV KolodnytskaV requested a review from vadiimvooo April 1, 2026 12:22
Copy link
Copy Markdown

@2pasha 2pasha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job! 👏

here are some improvements:

  1. fix moments from fe_chat
  2. these links don't work
Image
  1. add hover effects for your elements like these
Image
  1. it's better to use icons in svg format with the same style and you may add some hover effect
Image
  1. add form validation
  • all fields should be required
  • add email validation
  • after submitting form form should be cleaned, without any side effects
    to implement these you may use this:
<form onsubmit="this.reset(); return false;">
Image
  1. tablet and mobile views look broken

@KolodnytskaV
Copy link
Copy Markdown
Author

I can't fix a problem with the slider in the header. I also have a problem with smooth transitions between different screen sizes.

@KolodnytskaV KolodnytskaV requested a review from 2pasha April 7, 2026 20:09
Copy link
Copy Markdown

@brespect brespect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost done, but this header swiper looks broken, if you have any questions you may write in fe_chat

@KolodnytskaV KolodnytskaV requested a review from brespect April 8, 2026 16:06
Copy link
Copy Markdown

@Anton-Kuchmasov Anton-Kuchmasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost done!

Please fix CSS Autofill styles in your Form
no additional styles (e.g. background-color or whatever else changes) allowed

Image

@KolodnytskaV
Copy link
Copy Markdown
Author

I resolved this problem, but I still have a problem with image in header

Copy link
Copy Markdown

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost done

  1. all fields should be required
Image
  1. these should be links
Image
  1. centre this section
Image

@KolodnytskaV KolodnytskaV requested a review from etojeDenys April 8, 2026 18:35
Copy link
Copy Markdown

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. there is still a problem with steps 1 and 3 from the previous review

  2. fix the style of the links (remove base underline and text color)

Image

@KolodnytskaV KolodnytskaV requested a review from etojeDenys April 8, 2026 19:42
@KolodnytskaV
Copy link
Copy Markdown
Author

can't center testimonials_cards and fix a problem with image in header

Copy link
Copy Markdown

@brespect brespect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide the DEMO LINK in Pull Request description, and make sure it is working, if you have any problems ask in fe_chat

@KolodnytskaV KolodnytskaV requested a review from brespect April 10, 2026 14:24
Copy link
Copy Markdown

@Anton-Kuchmasov Anton-Kuchmasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DEMO_LINK: https://kolodnytskav.github.io/layout_dia/

hey, to proceed with your landing page, you should make some changes:

  1. Centering the Testimonials cards: use justify-content: center for the testimonials__cards div:
Image
  1. Fixing the layout of Slider:
Image

2.1 Add margin-top on div with class container strategic__container with correct value (retreive it from Figma mockup - i've added 100px as an example):

2.2. Add correct width to div with strategic__image class. I've added 50%, but again - you should check the right value in Figma

Image

2.3. Add border-top-left-radius: 200px to slightly round your Slider. Do it again with with .header to style background of your border (border-bottom-left should work)

Image

2.4. Disable width: 400% on .slides div

2.5. Make section class ="strategic" as relative (just add position: relative).
Let's position container strategic__container div:

image
  1. Analyze further styles to make your solution perfect.
    You can use this solution as a reference

Copy link
Copy Markdown

@Denys-Kravchuk9988 Denys-Kravchuk9988 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

A few things to improve:

  1. It's better to align slider according to the design
Image Image
  1. I would recommend to remove default button's border width
Image Image
  1. Part of the visit us text is hidden
Image Image
  1. It's better to export icons and logos in .svg format
Image Image

Copy link
Copy Markdown

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost done

  1. now is prone version looks a bit broken. adjust these sections for the phone version
Image Image Image

@KolodnytskaV KolodnytskaV requested a review from etojeDenys April 20, 2026 22:23
Copy link
Copy Markdown

@brespect brespect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost done, but i think:

  1. this text should be inside header image:
Image
  1. Check the swiper buttons, as for me, not working properly

@KolodnytskaV KolodnytskaV requested a review from brespect April 21, 2026 12:07
Copy link
Copy Markdown

@brespect brespect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants