design for 1600px#1166
Conversation
etojeDenys
left a comment
There was a problem hiding this comment.
if you have any issues, feel free to ask for help in the chat, because it's hard to communicate here
etojeDenys
left a comment
There was a problem hiding this comment.
demo link does not work. please fix it and re-request the review
vadiimvooo
left a comment
There was a problem hiding this comment.
There are still no demo link in the description of PR and deploy. Please feel free to ask for help in fe_chat.
2pasha
left a comment
There was a problem hiding this comment.
good job! 👏
here are some improvements:
- fix moments from fe_chat
- these links don't work
- add hover effects for your elements like these
- it's better to use icons in
svgformat with the same style and you may add some hover effect
- add form validation
- all fields should be required
- add email validation
- after submitting form form should be cleaned, without any side effects
to implement these you may use this:
<form onsubmit="this.reset(); return false;">
- tablet and mobile views look broken
|
I can't fix a problem with the slider in the header. I also have a problem with smooth transitions between different screen sizes. |
brespect
left a comment
There was a problem hiding this comment.
Almost done, but this header swiper looks broken, if you have any questions you may write in fe_chat
Anton-Kuchmasov
left a comment
There was a problem hiding this comment.
Almost done!
Please fix CSS Autofill styles in your Form
no additional styles (e.g. background-color or whatever else changes) allowed
|
I resolved this problem, but I still have a problem with image in header |
|
can't center testimonials_cards and fix a problem with image in header |
brespect
left a comment
There was a problem hiding this comment.
Please provide the DEMO LINK in Pull Request description, and make sure it is working, if you have any problems ask in fe_chat
There was a problem hiding this comment.
DEMO_LINK: https://kolodnytskav.github.io/layout_dia/
hey, to proceed with your landing page, you should make some changes:
- Centering the
Testimonialscards: usejustify-content: centerfor thetestimonials__cardsdiv:
- Fixing the layout of Slider:
2.1 Add margin-top on div with class container strategic__container with correct value (retreive it from Figma mockup - i've added 100px as an example):
2.2. Add correct width to div with strategic__image class. I've added 50%, but again - you should check the right value in Figma
2.3. Add border-top-left-radius: 200px to slightly round your Slider. Do it again with with .header to style background of your border (border-bottom-left should work)
2.4. Disable width: 400% on .slides div
2.5. Make section class ="strategic" as relative (just add position: relative).
Let's position container strategic__container div:
- Analyze further styles to make your solution perfect.
You can use this solution as a reference
















I finished design for 1600px but I have some problems with @media and import in main.css