Solution. https://SerhiyDmytruk.github.io/layout_dia/#1164
Open
SerhiyDmytruk wants to merge 7 commits into
Open
Solution. https://SerhiyDmytruk.github.io/layout_dia/#1164SerhiyDmytruk wants to merge 7 commits into
SerhiyDmytruk wants to merge 7 commits into
Conversation
Anton-Kuchmasov
suggested changes
Mar 25, 2026
Anton-Kuchmasov
left a comment
Anton-Kuchmasov
left a comment
There was a problem hiding this comment.
DEMO LINK: https://serhiydmytruk.github.io/layout_dia
Good job!
To improve:
-
Please add some
hovereffects on each link in the Header nav (as well as in the Footer' nav) -
Tablet view:
Figma:
Would you mind to fix it?
- Clicking on
Sendbutton should only erase all entered data - no side effects like page-scrolling allowed. Check out #15 of this instruction to proceed
etojeDenys
suggested changes
Mar 26, 2026
etojeDenys
left a comment
etojeDenys
left a comment
There was a problem hiding this comment.
great job, just last fix
- you should add some space here
example:
Author
|
My bad - added correct width for container, now same as header |
brespect
suggested changes
Mar 26, 2026
brespect
left a comment
brespect
left a comment
There was a problem hiding this comment.
Almost done, check next:
- This section looks different from the mockup:
- Nothing happens by clicking here:
- Footer links on Mobile look different from the mockup:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.