Skip to content

https://AlonaMelnyk004.github.io/layout_dia/#1160

Open
AlonaMelnyk004 wants to merge 6 commits into
mate-academy:masterfrom
AlonaMelnyk004:develop
Open

https://AlonaMelnyk004.github.io/layout_dia/#1160
AlonaMelnyk004 wants to merge 6 commits into
mate-academy:masterfrom
AlonaMelnyk004:develop

Conversation

@AlonaMelnyk004
Copy link
Copy Markdown

Copy link
Copy Markdown

@2pasha 2pasha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job! 👏

here are some improvements:

  1. this section should be centered
Image
  1. all sections should be centered
Image
  1. use logo in svg format
Image
  1. on tablet the same issue with sections centering

@AlonaMelnyk004 AlonaMelnyk004 requested a review from 2pasha April 2, 2026 17:05
Copy link
Copy Markdown

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. remove base outline
Image
  1. there is still a problem with that space
Image

Copy link
Copy Markdown

@Anton-Kuchmasov Anton-Kuchmasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost done!

  1. Please fix CSS Autofill styles here - no additional styles (e.g. background-color) allowed:
Image

Copy link
Copy Markdown

@2pasha 2pasha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job! 👏

here are last improvements:

  1. issue with centering is still actual. You may fix this with justify-content: center;
Image
  1. this section looks broken on tablet
Image
  1. you shouldn't trim your worlds
Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants