Skip to content

Catalog-hovers #1997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kacper-Leman wants to merge 4 commits into
base: master
Choose a base branch
from
+12 −1
Open

Catalog-hovers #1997

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cc0cfae
readme.md
Kacper-Leman Jun 5, 2023
e160393
Catalog-hovers soultion
Kacper-Leman Jun 5, 2023
beb4101
change transition in Header
Kacper-Leman Jun 6, 2023
4ee4034
Fixing animation
Kacper-Leman Jun 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Frontend practice with catalog page and hovers
Replace `<your_account>` with your Github username and copy the links to Pull Request description:
- [DEMO LINK](https://<your_account>.github.io/layout_catalog_hovers/)
- [DEMO LINK](https://Kacper-Leman.github.io/layout_catalog_hovers/)

> Follow [this instructions](https://github.com/mate-academy/layout_task-guideline#how-to-solve-the-layout-tasks-on-github)

Expand Down
8 changes: 8 additions & 0 deletions src/styles/blocks/catalog.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,16 @@
border-radius: 5px;
margin-bottom: 48px;

transition: color $delayValue, transform $delayValue;

&:not(:nth-child(4n)) {
margin-right: 48px;
}
}

&__card:hover {
transform: scale(1.2);

color: #34568b;
}
}
5 changes: 5 additions & 0 deletions src/styles/blocks/header.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,4 +39,9 @@
font-size: 12px;
font-weight: 500;
}

&__link:hover {
transition: color $delayValue;
color: #00acdc;
}

@DorotaLeniecDev DorotaLeniecDev Jun 7, 2023

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put transition to origin element not hover to make animation smooth in both directions:

Suggested change
&__link:hover {
transition: color $delayValue;
color: #00acdc;
}
&__link {
transition: color $delayValue;
}

}
1 change: 1 addition & 0 deletions src/styles/main.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
@import "./utils/variables";
@import "blocks/page";
@import "blocks/header";
@import "blocks/catalog";
1 change: 1 addition & 0 deletions src/styles/utils/_variables.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
$delayValue: 300ms;