Skip to content

catalog_grid 1 #1925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
usernameluke wants to merge 2 commits into
base: master
Choose a base branch
from
Open

catalog_grid 1 #1925

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
17b51b7
catalog_grid 1
usernameluke Oct 23, 2023
d46e8da
catalog_grid 2
usernameluke Oct 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Frontend practice with catalog page using grid
Replace `<your_account>` with your Github username and copy the links to Pull Request description:
- [DEMO LINK](https://<your_account>.github.io/layout_catalog_grid/)
- [DEMO LINK](https://usernameluke.github.io/layout_catalog_grid/)

> Follow [this instructions](https://github.com/mate-academy/layout_task-guideline#how-to-solve-the-layout-tasks-on-github)

Expand Down
20 changes: 10 additions & 10 deletions src/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,39 +13,39 @@
>
<link href="https://fonts.googleapis.com/css2?family=Roboto:wght@300;400;500&display=swap" rel="stylesheet">

<link rel="stylesheet" href="./styles/main.scss">
<link rel="stylesheet" href="./styles/main.css">
</head>
<body>
<header class="header">
<a class="header__logo" href="">
<a class="header__logo" href="#">
<img src="./images/logo.png" alt="Moyo logo">
</a>

<nav class="nav">
<ul class="nav__list">
<li class="nav__item nav__item--is-active">
<a href="" class="nav__link">Apple</a>
<a href="#" class="nav__link">Apple</a>
</li>
<li class="nav__item">
<a href="" class="nav__link">Samsung</a>
<a href="#" class="nav__link">Samsung</a>
</li>
<li class="nav__item">
<a href="" class="nav__link">Smartphones</a>
<a href="#" class="nav__link">Smartphones</a>
</li>
<li class="nav__item">
<a href="" class="nav__link">Laptops & computers</a>
<a href="#" class="nav__link">Laptops & computers</a>
</li>
<li class="nav__item">
<a href="" class="nav__link">Gadgets</a>
<a href="#" class="nav__link">Gadgets</a>
</li>
<li class="nav__item">
<a href="" class="nav__link">Tablets</a>
<a href="#" class="nav__link">Tablets</a>
</li>
<li class="nav__item">
<a href="" class="nav__link">Photo</a>
<a href="#" class="nav__link">Photo</a>
</li>
<li class="nav__item">
<a href="" class="nav__link">Video</a>
<a href="#" class="nav__link">Video</a>
</li>
</ul>
</nav>
Expand Down
28 changes: 20 additions & 8 deletions src/styles/_catalog.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
.catalog {
display: flex;
flex-wrap: wrap;

max-width: 944px;
margin: 0 auto;
display: grid;
gap: 48px;
grid-template-columns: 200px 200px 200px 200px;
Copy link
Copy Markdown

@anastasiia-tilikina anastasiia-tilikina Oct 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use repeat function

Copy link
Copy Markdown

@anastasiia-tilikina anastasiia-tilikina Oct 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix everywhere

justify-content: center;

&__card {
display: flex;
Expand All @@ -13,10 +12,23 @@
height: 300px;
border: 1px solid #ccc;
border-radius: 5px;
margin-bottom: 48px;
}
}

@media (max-width: 487px) {
.catalog {
grid-template-columns: auto;
}
}

@media (min-width: 488px) and (max-width: 767px) {
.catalog {
grid-template-columns: 200px 200px;
}
}

&__card:not(:nth-child(4n)) {
margin-right: 48px;
@media (min-width: 768px) and (max-width: 1023px) {
.catalog {
grid-template-columns: 200px 200px 200px;
}
}
86 changes: 86 additions & 0 deletions src/styles/main.css
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions src/styles/main.css.map
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.