catalog grid 1#1924
Open
steveforde wants to merge 8 commits into
Open
Conversation
steveforde
commented
Aug 2, 2023
steveforde
commented
- DEMO LINK
maxim2310
suggested changes
Aug 3, 2023
lerastarynets
suggested changes
Aug 3, 2023
lerastarynets
left a comment
lerastarynets
left a comment
There was a problem hiding this comment.
Cards should be centred horizontally on your page for all the media queries, however now it's not(
Pls fix
Anastasiia-Svintsova
suggested changes
Aug 3, 2023
maxim2310
suggested changes
Aug 3, 2023
maxim2310
left a comment
maxim2310
left a comment
There was a problem hiding this comment.
you cards still aren't centered, remove this rules for fix
maxim2310
suggested changes
Aug 3, 2023
maxim2310
left a comment
maxim2310
left a comment
There was a problem hiding this comment.
and one more things
https://www.loom.com/share/0d55c46c0a554aa49415208da7ca44ce
maxim2310
suggested changes
Aug 4, 2023
| grid-gap: 48px; | ||
| max-width: 944px; | ||
| margin: 0 auto; | ||
| justify-content: center; |
There was a problem hiding this comment.
Suggested change
| justify-content: center; | |
| justify-items: center; |
Anastasiia-Svintsova
suggested changes
Aug 4, 2023
Anastasiia-Svintsova
left a comment
Anastasiia-Svintsova
left a comment
There was a problem hiding this comment.
- There are still redundant spaces between the cards
| align-items: center; | ||
|
|
||
| @media (min-width: 1024px) { | ||
| grid-template-columns: repeat(4, 1fr); |
There was a problem hiding this comment.
Here is the reason. Create a variable for the card width and use it
$card-width: 200px;
Suggested change
| grid-template-columns: repeat(4, 1fr); | |
| grid-template-columns: repeat(4, $card-width); |
Comment on lines
+36
to
+39
| .catalog__card:nth-child(3n + 1), | ||
| .catalog__card:nth-child(3n + 2), | ||
| .catalog__card:nth-child(3n + 3) { | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.