Solution added#1913
Open
kyrylomanko wants to merge 2 commits into
Open
Conversation
kyrylomanko
commented
Jun 11, 2023
kyrylomanko
commented
- DEMO LINK
Anastasiia-Svintsova
suggested changes
Jun 12, 2023
| border-radius: 5px; | ||
| } | ||
|
|
||
| &__card:not(:nth-child(4n)) { |
There was a problem hiding this comment.
Remove unnecessary margin-right style for cards since the gap property in the grid layout is already handling the space between cards.
| justify-content: center; | ||
| gap: 48px; | ||
|
|
||
| max-width: 944px; |
There was a problem hiding this comment.
You don't need to add a max width here. Just use the grid template
| } | ||
| } | ||
|
|
||
| @media (max-width: 1023) { |
There was a problem hiding this comment.
Use correct breakpoints for the media queries. Check all breakpoints, please
qoa11a
approved these changes
Jun 13, 2023
| # Frontend practice with catalog page using grid | ||
| Replace `<your_account>` with your Github username and copy the links to Pull Request description: | ||
| - [DEMO LINK](https://<your_account>.github.io/layout_catalog_grid/) | ||
| - [DEMO LINK](https://kyrylomanko.github.io/layout_catalog_grid/) |
There was a problem hiding this comment.
Suggested change
| - [DEMO LINK](https://kyrylomanko.github.io/layout_catalog_grid/) | |
| - [DEMO LINK](https://kyrylomanko.github.io/layout_catalog_grid/) |
| .catalog { | ||
| display: grid; | ||
| justify-content: center; | ||
| margin: 0 auto; |
There was a problem hiding this comment.
It's redundant as the width is 100% anyway and top and bottom margins are zero by default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.