Catalog-grid#1910
Open
Kacper-Leman wants to merge 3 commits into
Open
Conversation
darokrk
approved these changes
Jun 9, 2023
darokrk
left a comment
darokrk
left a comment
There was a problem hiding this comment.
Approved 👍🏽 good job, but please look at my mentions and fix them before you go next :)
| </li> | ||
| <li class="nav__item"> | ||
| <a href="" class="nav__link">Laptops & computers</a> | ||
| <a href="#laptopts" class="nav__link">Laptops & computers</a> |
There was a problem hiding this comment.
Fix the typo in the 'href' attribute value. Change '#laptopts' to '#laptops'
| gap: 48px; | ||
| justify-content: center; | ||
| margin: 0 auto; | ||
| grid-template-columns: repeat(1, $cardWidth); |
There was a problem hiding this comment.
I think you don't need this value here, they will always set automatically 1 element in breakpoint below 488px
|
|
||
| &__card:not(:nth-child(4n)) { | ||
| margin-right: 48px; | ||
| @media (min-width: 488px) { |
There was a problem hiding this comment.
Generally good practice is to use whole styling properties for each class in one place. So those breakpoints are for .catalog class so move them up before &__card and not behind as you do now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://Kacper-Leman.github.io/layout_catalog_grid/ -Demo Link