Solution of this task#677
Open
IvanovYurii wants to merge 3 commits into
Open
Conversation
Ivan95kos
suggested changes
Aug 13, 2023
| import taxi.service.AuthenticationServiceImpl; | ||
|
|
||
| public class LoginController extends HttpServlet { | ||
| private final AuthenticationService authenticationService = new AuthenticationServiceImpl(); |
There was a problem hiding this comment.
Use the Injector to initialize services
| Driver driver = authenticationService.login(login, password); | ||
| HttpSession session = req.getSession(); | ||
| session.setAttribute("driver_id", driver.getId()); | ||
| resp.sendRedirect("/index"); |
There was a problem hiding this comment.
fix it everywhere
Suggested change
| resp.sendRedirect("/index"); | |
| resp.sendRedirect(req.getContextPath() + "/index"); |
Fix resp.sendRedirect("/index")
Remove unused variable in LogoutController.java
Rename same inscriptions in HTML
Ivan95kos
approved these changes
Aug 13, 2023
| @@ -27,9 +29,30 @@ public void doGet(HttpServletRequest req, HttpServletResponse resp) | |||
| public void doPost(HttpServletRequest req, HttpServletResponse resp) throws IOException { | |||
There was a problem hiding this comment.
A lot of try-catch, return the previous version
… lot of try-catch, return the previous version)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.