add my solution#672
Open
mykhailoKrlKrk wants to merge 4 commits into
Open
Conversation
kozhukhovsky
suggested changes
Aug 6, 2023
| Driver driver = authenticationService.login(username, password); | ||
| HttpSession session = req.getSession(); | ||
| session.setAttribute("driver_id",driver.getId()); | ||
| resp.sendRedirect("/index"); |
| session.setAttribute("driver_id",driver.getId()); | ||
| resp.sendRedirect("/index"); | ||
| } catch (AuthenticationException e) { | ||
| req.setAttribute("errorMsg",e.getMessage()); |
There was a problem hiding this comment.
Suggested change
| req.setAttribute("errorMsg",e.getMessage()); | |
| req.setAttribute("errorMsg" ,e.getMessage()); |
| protected void doGet(HttpServletRequest req, HttpServletResponse resp) | ||
| throws ServletException, IOException { | ||
| req.getSession().invalidate(); | ||
| resp.sendRedirect("/index"); |
Comment on lines
+214
to
+215
| String login = resultSet.getString("login"); | ||
| String password = resultSet.getString("password"); |
There was a problem hiding this comment.
Does it work? You from request do not pull these fields.
|
|
||
| @Override | ||
| public Driver login(String login, String password) throws AuthenticationException { | ||
|
|
| HttpSession session = request.getSession(); | ||
|
|
||
| Long driverId = (Long) session.getAttribute("driver_id"); | ||
| if (driverId == null && allowedUrls.contains(request.getServletPath())) { |
kozhukhovsky
approved these changes
Aug 6, 2023
| Long driverId = resultSet.getObject("id", Long.class); | ||
| String name = resultSet.getString("name"); | ||
| String licenseNumber = resultSet.getString("license_number"); | ||
| String login = resultSet.getString("login"); |
There was a problem hiding this comment.
You need to leave, just add these fields to the request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.