pull request#1918
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
The PR introduces a checklist violation in Box.java — there is an empty line between the package declaration and the class definition, which violates checklist item #1. While this is a style issue, checklist items are explicit requirements that must be followed. Please remove the blank line at the beginning of the file. Note that the StorageImpl.java implementation also needs attention (tests are failing due to stub methods), but that file was not modified in this submission, so the focus here is on fixing the style violation in Box.java.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
| @@ -0,0 +1,4 @@ | |||
| package core.basesyntax.impl; | |||
|
|
|||
There was a problem hiding this comment.
Remove this empty line. According to checklist item #1, class implementations should not begin with an empty line.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Your solution is approved. The StorageImpl.java correctly implements all required functionality: the put(key, value) method adds new pairs and replaces existing keys, get(key) retrieves values properly, size() returns the current count, and the storage uses two arrays as specified. The MAX_CAPACITY = 10 constant is defined, all fields are properly initialized in the constructor, and variable names are clear and informative. Great work implementing the generic Storage<K,V> interface with the array-based approach—everything meets the task specifications.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
No description provided.