Skip to content

i have done #1913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
IgnisVictima wants to merge 2 commits into
base: master
Choose a base branch
from
Open

i have done #1913

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa60d5c
i have done
IgnisVictima May 9, 2026
095f801
final
IgnisVictima May 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 35 additions & 1 deletion src/main/java/core/basesyntax/impl/StorageImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,17 +3,51 @@
import core.basesyntax.Storage;

public class StorageImpl<K, V> implements Storage<K, V> {
private static final int MAX_STORAGE_CAPACITY = 10;
private final Object[] keys;
private final Object[] values;
private int size;

public StorageImpl() {
keys = new Object[MAX_STORAGE_CAPACITY];
values = new Object[MAX_STORAGE_CAPACITY];
size = 0;
}

@Override
public void put(K key, V value) {
for (int i = 0; i < size; i++) {

if (keys[i] == null ? key == null : keys[i].equals(key)) {
Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor May 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CHECKLIST VIOLATION #4: This null-safe equality check is duplicated in get() method at line 39. Extract this logic into a private helper method (e.g., areKeysEqual(Object storedKey, K searchKey)) to follow the DRY principle.


values[i] = value;
return;
}
}

keys[size] = key;
values[size] = value;

size++;

}

@Override
public V get(K key) {
Comment on lines 35 to 36
Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor May 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty line at start of method implementation - remove redundant empty line.

for (int i = 0; i < size; i++) {

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor May 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replaces existing key's value - uses Objects.equals which is not allowed per checklist requirements.

if (keys[i] == null ? key == null : keys[i].equals(key)) {

return (V) values[i];
}

}
return null;

}
Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor May 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty line at start of method implementation - remove redundant empty line.


@Override
public int size() {
return -1;
return size;
}
}
Loading