Skip to content

feat: implement custom HashMap storage #1908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RodionPlakhotniuk wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: implement custom HashMap storage #1908

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
520ed55
feat: implement custom HashMap storage
RodionPlakhotniuk Apr 22, 2026
fb6c6e6
fix: apply mentor comments
RodionPlakhotniuk Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 39 additions & 1 deletion src/main/java/core/basesyntax/impl/StorageImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,17 +3,55 @@
import core.basesyntax.Storage;

public class StorageImpl<K, V> implements Storage<K, V> {
private static final int MAX_SIZE = 10;
private int size;
Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'size' field should be explicitly initialized in the constructor. According to the checklist, all non-constant fields must be initialized in the constructor.

private K[] keys;
private V[] values;

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty line at the beginning of the constructor implementation. This is before the constructor body starts.

@SuppressWarnings("unchecked")
public StorageImpl() {
this.size = 0;
keys = (K[]) new Object[MAX_SIZE];
values = (V[]) new Object[MAX_SIZE];
}

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty line at the beginning of the 'put' method implementation. The @OverRide annotation on line 18 marks the start of the method, and there should be no empty line before it.

@Override
public void put(K key, V value) {
int index = findKeyIndex(key);

if (index != -1) {
values[index] = value;
return;
}
if (size == MAX_SIZE) {
throw new IllegalStateException("Storage is full");
}
keys[size] = key;
values[size] = value;
size++;
}

@Override
public V get(K key) {
return null;
int index = findKeyIndex(key);
if (index == -1) {
return null;
}
return values[index];
}

@Override
public int size() {
return size;
}

private int findKeyIndex(K key) {
for (int i = 0; i < size; i++) {
if ((keys[i] == null && key == null)
|| (keys[i] != null && keys[i].equals(key))) {
return i;
}
}
return -1;
}
}
Loading