task competed#1899
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Great job on implementing the Storage functionality! Your code correctly handles all the core requirements for adding and retrieving data. However, changes are needed because there's a significant amount of duplicated code. In StorageImpl.java, the logic for finding a key's index is repeated in both the put and get methods. This violates a key principle of writing clean code and goes against one of the task's requirements: 'Don't create repeating code' [CHECKLIST ITEM #5]. To fix this, please extract the search logic into a single private helper method. Both put and get can then call this new method to find the index, making your code more maintainable and easier to read. Once you've refactored this, your solution will be in great shape!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
| for (int i = 0; i < size; i++) { | ||
| if ((key == null && this.keys[i] == null) | ||
| || (this.keys[i] != null && this.keys[i].equals(key))) { | ||
| this.values[i] = value; | ||
| return; | ||
| } | ||
| } |
There was a problem hiding this comment.
This loop for finding a key is nearly identical to the one in the get method. This violates checklist item #5: 'Don't create repeating code'. Consider extracting this search logic into a separate private helper method that returns the index of a given key. Both put and get methods could then use this helper method to avoid code duplication.
| for (int i = 0; i < size; i++) { | ||
| if ((key == null && this.keys[i] == null) | ||
| || (this.keys[i] != null && this.keys[i].equals(key))) { | ||
| return this.values[i]; | ||
| } | ||
| } |
There was a problem hiding this comment.
This logic for finding a key is a duplicate of the logic in the put method. As per checklist item #5, you should move this repeated logic to a separate private method to avoid redundancy and improve the code's structure.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Excellent work on this iteration! I am approving your solution. You've successfully addressed the previous feedback by extracting the key-finding logic into a private helper method. This significantly improves the code's readability and maintainability by following the DRY principle. Your solution now fully meets all the task requirements. Great job!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
No description provided.