V1 #2470

PiotrHic · 2025-10-25T16:21:02Z

My V1 of the task

mateacademy-ai-mentor

Sorry, the pull request review was unsuccessful for the following reasons:

Warning

The test task has already been approved.
_{[CODE: AAP]}

If the issue is within your control, please address it.
The next review attempt will automatically launch in about 1 hour.
If you believe this is an error or need assistance, please contact the support team.

mateacademy-ai-mentor

Sorry, the pull request review was unsuccessful for the following reasons:

Warning

The test task has already been approved.
_{[CODE: AAP]}

If the issue is within your control, please address it.
The next review attempt will automatically launch in about 1 hour.
If you believe this is an error or need assistance, please contact the support team.

mateacademy-ai-mentor

Sorry, the pull request review was unsuccessful for the following reasons:

Warning

The test task has already been approved.
_{[CODE: AAP]}

If the issue is within your control, please address it.
The next review attempt will automatically launch in about 1 hour.
If you believe this is an error or need assistance, please contact the support team.

mateacademy-ai-mentor

Sorry, the pull request review was unsuccessful for the following reasons:

Warning

The test task has already been approved.
_{[CODE: AAP]}

If the issue is within your control, please address it.
The next review attempt will automatically launch in about 1 hour.
If you believe this is an error or need assistance, please contact the support team.

slade13

Please fix those minor problems and send your task again for a review.
There are too many commits as for such simple task, there could be one commit called:
feat(oop): implement Machine hierarchy and demo polymorphism

For each added class you've added single commit.

This commit has a typo: Trock Class -> 'Truck Class' -> but still it does not say anything about what was done. Was it changed/added/removed? Commi messages should be informative.
This one is also bad: src/main/java/core/basesyntax/Excavator.java

And this one is so general that it doesn't have any sense: Final commit

Start you commit messages lowercase, use informative messages, for example you have to add service implementation for car rental app:
`add implementation for car rental system service' -> lowercase, informative and says what was done there.

Inside commit messages you can also add description which will be more detailed.

slade13 · 2025-10-27T09:26:57Z

src/main/java/core/basesyntax/Truck.java

+
+    @Override
+    public void doWork() {
+        System.out.println("Track starts wrrrr....");


Suggested change

System.out.println("Track starts wrrrr....");

System.out.println("Truck starts wrrrr....");

slade13 · 2025-10-27T09:27:07Z

src/main/java/core/basesyntax/Truck.java

+
+    @Override
+    public void stopWork() {
+        System.out.println("Track stops....");


Suggested change

System.out.println("Track stops....");

System.out.println("Truck stops....");

slade13 · 2025-10-27T09:27:31Z

src/main/java/core/basesyntax/Excavator.java

+public class Excavator extends Machine {
+    @Override
+    public void doWork() {
+        System.out.println("Excavatore starts...");


Suggested change

System.out.println("Excavatore starts...");

System.out.println("Excavator starts...");

slade13 · 2025-10-27T09:27:47Z

src/main/java/core/basesyntax/Excavator.java

+
+    @Override
+    public void stopWork() {
+        System.out.println("Excavatore stops...");


Suggested change

System.out.println("Excavatore stops...");

System.out.println("Excavator stops...");

slade13 · 2025-10-27T09:28:04Z

src/main/java/core/basesyntax/Bulldozer.java

+
+    @Override
+    public void doWork() {
+        System.out.println("Bulldozer starts.....");


Messages like "....."/"wrrrr" are noisy; the checklist asks for informative messages.

slade13 · 2025-10-27T09:28:26Z

src/main/java/core/basesyntax/Truck.java

+
+    @Override
+    public void stopWork() {
+        System.out.println("Track stops....");


Messages like "....."/"wrrrr" are noisy; the checklist asks for informative messages.

slade13 · 2025-10-27T09:29:07Z

src/main/java/core/basesyntax/Bulldozer.java

+package core.basesyntax;
+
+public class Bulldozer extends Machine {
+


Remove this redundant empty line.

slade13 · 2025-10-27T09:29:16Z

src/main/java/core/basesyntax/Truck.java

+package core.basesyntax;
+
+public class Truck extends Machine {
+


Remove this redundant empty line.

slade13 · 2025-10-27T09:30:14Z

src/main/java/core/basesyntax/MainApp.java

 public class MainApp {
-
+    public static void main(String[] args) {
+        Machine [] machines = new Machine[]{new Truck(), new Excavator(), new Bulldozer()};


Conventional style is:

Suggested change

Machine [] machines = new Machine[]{new Truck(), new Excavator(), new Bulldozer()};

Machine[] machines = new Machine[] {new Truck(), new Excavator(), new Bulldozer()};

slade13 · 2025-10-27T09:30:46Z

src/main/java/core/basesyntax/MainApp.java

-
+    public static void main(String[] args) {
+        Machine [] machines = new Machine[]{new Truck(), new Excavator(), new Bulldozer()};
+        for (Machine machine: machines) {


Enhanced for-loop spacing:

Suggested change

for (Machine machine: machines) {

for (Machine machine : machines) {

PiotrHic added 7 commits October 25, 2025 16:20

Machine class

9951a3a

Fix Machine

0c3bd86

Trock Class

2ca9988

Bulldozer Class

b2ae3a0

src/main/java/core/basesyntax/Excavator.java

c71dd33

Machine fix

7f2b687

Final commit

1eccd0b

mateacademy-ai-mentor reviewed Oct 25, 2025

View reviewed changes

slade13 suggested changes Oct 27, 2025

View reviewed changes

	System.out.println("Track starts wrrrr....");
	System.out.println("Truck starts wrrrr....");

	System.out.println("Track stops....");
	System.out.println("Truck stops....");

	System.out.println("Excavatore starts...");
	System.out.println("Excavator starts...");

	System.out.println("Excavatore stops...");
	System.out.println("Excavator stops...");

		package core.basesyntax;

		public class Bulldozer extends Machine {

		package core.basesyntax;

		public class Truck extends Machine {

	Machine [] machines = new Machine[]{new Truck(), new Excavator(), new Bulldozer()};
	Machine[] machines = new Machine[] {new Truck(), new Excavator(), new Bulldozer()};

	for (Machine machine: machines) {
	for (Machine machine : machines) {

V1 #2470

Are you sure you want to change the base?

V1 #2470

Uh oh!

Conversation

PiotrHic commented Oct 25, 2025

Uh oh!

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

Uh oh!

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

Uh oh!

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

Uh oh!

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

Uh oh!

slade13 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants