-
Notifications
You must be signed in to change notification settings - Fork 1.8k
feat: CompleteCompleted jv-oop Machine inheritance taskd jv-oop Machine inheritance task #2463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Summary
Your solution is approved. You correctly implemented the abstract class Machine with doWork() and stopWork(), provided concrete subclasses (Truck, Bulldozer, Excavator) that print appropriate English messages, and used polymorphism in MainApp to iterate over a Machine[]. Functionality is complete and behaves as required.
Minor style notes (non-blocking):
- In
src/main/java/core/basesyntax/Bulldozer.java: remove the empty line right after the package declaration (line 2) and the extra empty line between the two methods (around the line separatingdoWork()andstopWork()). - In
src/main/java/core/basesyntax/Truck.java: remove the empty line after the package declaration (line 2) and the extra blank line between methods (betweendoWork()andstopWork()).
These adjustments align with the checklist guidance to avoid redundant empty lines. Nice work demonstrating abstraction and polymorphism!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
| @@ -0,0 +1,13 @@ | |||
| package core.basesyntax; | |||
|
|
|||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file has a redundant empty line after the package declaration. The checklist explicitly says: "Please don't add redundant empty lines to your code. We don't need them after class declaration or method signature." Consider removing this blank line to follow the project's checklist and keep code compact.
| public void doWork() { | ||
| System.out.println("Bulldozer started its work."); | ||
| } | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file has an unnecessary empty line between the two method blocks. The checklist states: "Please don't add redundant empty lines to your code. We don't need them after class declaration or method signature." Remove this blank line to comply with the checklist.
| @@ -0,0 +1,13 @@ | |||
| package core.basesyntax; | |||
|
|
|||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line is a redundant empty line after the package declaration. The checklist says: "Please don't add redundant empty lines to your code. We don't need them after class declaration or method signature." Consider removing this blank line to follow the project's checklist.
| public void doWork() { | ||
| System.out.println("Truck started its work."); | ||
| } | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line is an unnecessary empty line between method blocks. The checklist says: "Please don't add redundant empty lines to your code. We don't need them after class declaration or method signature." Remove this blank line to comply with the checklist.
creating machines