Skip to content

Conversation

@Sibertdom
Copy link

creating machines

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Your solution is approved. You correctly implemented the abstract class Machine with doWork() and stopWork(), provided concrete subclasses (Truck, Bulldozer, Excavator) that print appropriate English messages, and used polymorphism in MainApp to iterate over a Machine[]. Functionality is complete and behaves as required.

Minor style notes (non-blocking):

  • In src/main/java/core/basesyntax/Bulldozer.java: remove the empty line right after the package declaration (line 2) and the extra empty line between the two methods (around the line separating doWork() and stopWork()).
  • In src/main/java/core/basesyntax/Truck.java: remove the empty line after the package declaration (line 2) and the extra blank line between methods (between doWork() and stopWork()).
    These adjustments align with the checklist guidance to avoid redundant empty lines. Nice work demonstrating abstraction and polymorphism!

✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

@@ -0,0 +1,13 @@
package core.basesyntax;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file has a redundant empty line after the package declaration. The checklist explicitly says: "Please don't add redundant empty lines to your code. We don't need them after class declaration or method signature." Consider removing this blank line to follow the project's checklist and keep code compact.

public void doWork() {
System.out.println("Bulldozer started its work.");
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file has an unnecessary empty line between the two method blocks. The checklist states: "Please don't add redundant empty lines to your code. We don't need them after class declaration or method signature." Remove this blank line to comply with the checklist.

@@ -0,0 +1,13 @@
package core.basesyntax;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is a redundant empty line after the package declaration. The checklist says: "Please don't add redundant empty lines to your code. We don't need them after class declaration or method signature." Consider removing this blank line to follow the project's checklist.

public void doWork() {
System.out.println("Truck started its work.");
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is an unnecessary empty line between method blocks. The checklist says: "Please don't add redundant empty lines to your code. We don't need them after class declaration or method signature." Remove this blank line to comply with the checklist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants