Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/main/java/core/basesyntax/Bulldozer.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
package core.basesyntax;

public class Bulldozer extends Machine {
@Override
public void doWork() {
System.out.println("Bulldozer started its work");
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This violates checklist item #1: "Do not add redundant empty lines after class declarations or method signatures". There is an extra blank line at line 8 between the end of doWork() and the @Override of stopWork() — remove that blank line so the method declarations appear consecutively. Refer to the checklist for the rule.

@Override
public void stopWork() {
System.out.println("Bulldozer stopped working");
}
}
13 changes: 13 additions & 0 deletions src/main/java/core/basesyntax/Excavator.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
package core.basesyntax;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This violates checklist item #1: "Do not add redundant empty lines after class declarations or method signatures". Remove the empty line after the package declaration so there are no redundant blank lines between package and the class declaration.

public class Excavator extends Machine {
@Override
public void doWork() {
System.out.println("Excavator started its work");
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This violates checklist item #1: "Do not add redundant empty lines after class declarations or method signatures". Remove the empty line between the end of doWork() and the @Override for stopWork() so the methods appear consecutively without redundant blank lines.

@Override
public void stopWork() {
System.out.println("Excavator stopped working");
}
}
7 changes: 7 additions & 0 deletions src/main/java/core/basesyntax/Machine.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
package core.basesyntax;

public abstract class Machine {
public abstract void doWork();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This violates checklist item #1: "Please don't add redundant empty lines to your code. We don't need them after class declaration or method signature."

There is a redundant empty line between the doWork() and stopWork() declarations. Remove the blank line at line 5 so the method declarations appear consecutively.

public abstract void stopWork();
}
12 changes: 11 additions & 1 deletion src/main/java/core/basesyntax/MainApp.java
Original file line number Diff line number Diff line change
@@ -1,5 +1,15 @@
package core.basesyntax;

public class MainApp {

public static void main(String[] args) {
Machine[] machineArray = new Machine[] {
new Truck(),
new Bulldozer(),
new Excavator()
};
for (Machine machine : machineArray) {
machine.doWork();
machine.stopWork();
}
}
}
13 changes: 13 additions & 0 deletions src/main/java/core/basesyntax/Truck.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
package core.basesyntax;

public class Truck extends Machine {
@Override
public void doWork() {
System.out.println("Truck started its work");
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This violates checklist item #1: "Please don't add redundant empty lines to your code. We don't need them after class declaration or method signature."

There is a redundant empty line between the doWork() and stopWork() methods (remove the blank line at line 8 so the methods appear consecutively).

@Override
public void stopWork() {
System.out.println("Truck stopped working");
}
}