-
Notifications
You must be signed in to change notification settings - Fork 1.8k
realize new classes and methods #2460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| package core.basesyntax; | ||
|
|
||
| public class Bulldozer extends Machine { | ||
| @Override | ||
| public void doWork() { | ||
| System.out.println("Bulldozer started its work"); | ||
| } | ||
|
|
||
| @Override | ||
| public void stopWork() { | ||
| System.out.println("Bulldozer stopped working"); | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| package core.basesyntax; | ||
|
|
||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This violates checklist item #1: "Do not add redundant empty lines after class declarations or method signatures". Remove the empty line after the package declaration so there are no redundant blank lines between |
||
| public class Excavator extends Machine { | ||
| @Override | ||
| public void doWork() { | ||
| System.out.println("Excavator started its work"); | ||
| } | ||
|
|
||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This violates checklist item #1: "Do not add redundant empty lines after class declarations or method signatures". Remove the empty line between the end of |
||
| @Override | ||
| public void stopWork() { | ||
| System.out.println("Excavator stopped working"); | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| package core.basesyntax; | ||
|
|
||
| public abstract class Machine { | ||
| public abstract void doWork(); | ||
|
|
||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This violates checklist item #1: "Please don't add redundant empty lines to your code. We don't need them after class declaration or method signature." There is a redundant empty line between the |
||
| public abstract void stopWork(); | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,15 @@ | ||
| package core.basesyntax; | ||
|
|
||
| public class MainApp { | ||
|
|
||
| public static void main(String[] args) { | ||
| Machine[] machineArray = new Machine[] { | ||
| new Truck(), | ||
| new Bulldozer(), | ||
| new Excavator() | ||
| }; | ||
| for (Machine machine : machineArray) { | ||
| machine.doWork(); | ||
| machine.stopWork(); | ||
| } | ||
| } | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| package core.basesyntax; | ||
|
|
||
| public class Truck extends Machine { | ||
| @Override | ||
| public void doWork() { | ||
| System.out.println("Truck started its work"); | ||
| } | ||
|
|
||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This violates checklist item #1: "Please don't add redundant empty lines to your code. We don't need them after class declaration or method signature." There is a redundant empty line between the |
||
| @Override | ||
| public void stopWork() { | ||
| System.out.println("Truck stopped working"); | ||
| } | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This violates checklist item #1: "Do not add redundant empty lines after class declarations or method signatures". There is an extra blank line at line 8 between the end of
doWork()and the@OverrideofstopWork()— remove that blank line so the method declarations appear consecutively. Refer to the checklist for the rule.