Skip to content

Conversation

@KhapalSofiia
Copy link

No description provided.

Copy link

@Elena-Bruyako Elena-Bruyako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's fix some comments

Comment on lines 19 to 23
if (users[i].getEmail().equals(email)) {
return users[i];
} else {
continue;
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (users[i].getEmail().equals(email)) {
return users[i];
} else {
continue;
}
if (user.getEmail().equals(email)) {
return user;
}

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Тобто тут краще використати цикл for each замість звичайного for?

Copy link
Contributor

@sarakhmen sarakhmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove redundant files (everything from .vs folder) from git. Take a look at 'git rm --cached', it may help you

* @return - user if his email is equal to passed email.
* Return <code>null</code> if there is no suitable user
*/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file and .vs directory shouldn't be added to git and pushed to github

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file and .vs directory shouldn't be added to git and pushed to github

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants