-
Notifications
You must be signed in to change notification settings - Fork 996
add login logic #1250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
add login logic #1250
Conversation
Elena-Bruyako
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's fix some comments
| if (users[i].getEmail().equals(email)) { | ||
| return users[i]; | ||
| } else { | ||
| continue; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| if (users[i].getEmail().equals(email)) { | |
| return users[i]; | |
| } else { | |
| continue; | |
| } | |
| if (user.getEmail().equals(email)) { | |
| return user; | |
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Тобто тут краще використати цикл for each замість звичайного for?
sarakhmen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove redundant files (everything from .vs folder) from git. Take a look at 'git rm --cached', it may help you
| * @return - user if his email is equal to passed email. | ||
| * Return <code>null</code> if there is no suitable user | ||
| */ | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this file and .vs directory shouldn't be added to git and pushed to github
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this file and .vs directory shouldn't be added to git and pushed to github
No description provided.