Skip to content
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
package mate.academy.service;

import mate.academy.model.User;

public class AuthenticationService {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public class AuthenticationService {
public class AuthenticationService {
private final UserService userService = new UserService();

/**
* Imagine that some user wants to login to your site.
Expand All @@ -11,6 +13,9 @@ public class AuthenticationService {
* Return false in any other cases.
*/
public boolean login(String email, String password) {
return false;
UserService userService = new UserService();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's better to make it class-level variable to avoid creating new UserService each time you call login method

Suggested change
UserService userService = new UserService();

User user = userService.findByEmail(email);

return user != null && user.getPassword().equals(password);
}
}
6 changes: 6 additions & 0 deletions src/main/java/mate/academy/service/UserService.java
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,12 @@ public class UserService {
* Return <code>null</code> if there is no suitable user
*/
public User findByEmail(String email) {
for (User user: users) {
if (user.getEmail().equals(email)) {
return user;
}
}

return null;
}
}