generated from mate-academy/jv-homework-template
-
Notifications
You must be signed in to change notification settings - Fork 995
implemented login and findByEmail #1244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Inna1989F
wants to merge
11
commits into
mate-academy:master
Choose a base branch
from
Inna1989F:auth-implementation
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 9 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
6c77b8a
implemented login and findByEmail
Inna1989F d60857f
implemented login and findByEmail
Inna1989F 6a14cba
implemented login and findByEmail Fixed
Inna1989F dbedefd
Merge remote-tracking branch 'origin/auth-implementation' into auth-i…
Inna1989F 182767f
implemented login and findByEmail Fixed 2
Inna1989F a30d74e
implemented login and findByEmail Fixed 2
Inna1989F fa9f7a0
Merge remote-tracking branch 'origin/auth-implementation' into auth-i…
Inna1989F 54f4ef5
Merge remote-tracking branch 'origin/auth-implementation' into auth-i…
Inna1989F 394fbd9
Merge remote-tracking branch 'origin/auth-implementation' into auth-i…
Inna1989F a61b9b3
Merge remote-tracking branch 'origin/auth-implementation' into auth-i…
Inna1989F cbd6389
Finish merge
Inna1989F File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
18 changes: 8 additions & 10 deletions
18
src/main/java/mate/academy/service/AuthenticationService.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,16 +1,14 @@ | ||
| package mate.academy.service; | ||
|
|
||
| import mate.academy.model.User; | ||
|
|
||
| public class AuthenticationService { | ||
| /** | ||
| * Imagine that some user wants to login to your site. | ||
| * You should check if user credentials (login and password) are valid or not. | ||
| * All users are stored in <code>UserService</code> class. | ||
| * @param email - user's email | ||
| * @param password - user's password | ||
| * @return true if user by email exists and passed password is equal to user's password. | ||
| * Return false in any other cases. | ||
| */ | ||
|
|
||
| private final UserService userService = new UserService(); | ||
|
|
||
| public boolean login(String email, String password) { | ||
| return false; | ||
| UserService userService = new UserService(); | ||
| User user = userService.findByEmail(email); | ||
| return user == null ? false : user.getPassword().equals(password); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion