hw jv-oop-lesson-0 solution #1240
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liliia-ponomarenko
suggested changes
Jul 30, 2025
liliia-ponomarenko
left a comment
liliia-ponomarenko
left a comment
There was a problem hiding this comment.
Good job! A few comments ;)
| * Return <code>null</code> if there is no suitable user | ||
| */ | ||
| public User findByEmail(String email) { | ||
| public static User findByEmail(String email) { |
There was a problem hiding this comment.
Suggested change
| public static User findByEmail(String email) { | |
| publiс User findByEmail(String email) { |
Don't make this method static
Comment on lines
14
to
15
| return (UserService.findByEmail(email) == null) ? false | ||
| : UserService.findByEmail(email).getPassword().equals(password); |
There was a problem hiding this comment.
Make UserService class-level variable. Call the method findByEmail only once
Elena-Bruyako
suggested changes
Jul 30, 2025
| */ | ||
| public boolean login(String email, String password) { | ||
| return false; | ||
| UserService userService = new UserService(); |
There was a problem hiding this comment.
it should be class-level variable
Elena-Bruyako
suggested changes
Jul 30, 2025
| * @return true if user by email exists and passed password is equal to user's password. | ||
| * Return false in any other cases. | ||
| */ | ||
| private static final UserService userService = new UserService(); |
There was a problem hiding this comment.
never create static mutable object
Suggested change
| private static final UserService userService = new UserService(); | |
| private final UserService userService = new UserService(); |
Elena-Bruyako
approved these changes
Jul 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.