test#1249
Conversation
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Your code still contains e.printStackTrace(); on line 17, which directly violates requirement #5 from the task description. This is a critical blocker that must be fixed before approval.
Required fixes:
-
Add SLF4J Logger import and initialization to
Main.java:import org.slf4j.Logger; import org.slf4j.LoggerFactory; private static final Logger logger = LoggerFactory.getLogger(Main.class);
-
Replace line 17
e.printStackTrace();with:logger.error("Your descriptive error message here", e);
-
Create
src/main/resources/logback.xmlwith File and Console appenders as specified in the task -
Update
.gitignoreto exclude log files (add*.logand log directory patterns)
The logger should provide informative context in error messages so debugging is possible without stack traces. Once these changes are made, your submission will meet all requirements.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
| @@ -15,6 +15,7 @@ public static void main(String[] args) { | |||
| user = authenticationService.login("bob", "1234"); | |||
| } catch (AuthenticationException e) { | |||
| e.printStackTrace(); | |||
There was a problem hiding this comment.
Replace e.printStackTrace(); with a logger method call. Example: logger.error("Authentication failed. Params: login=bob", e); This violates requirement #5 of the task description.
No description provided.