Jv logger solution#1248
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
The Java implementation is well-done with proper logger usage, informative messages, and correct .gitignore configuration. However, requirement #1 explicitly requires configuring the logger with File and Console appenders, and the log4j2.xml or log4j2.properties configuration file is missing from your submission. Without this configuration file, the logging system cannot function as specified. Please create and include the Log4j2 configuration file that defines both appenders. A typical structure would include a Console appender for stdout and a File appender configured to write to the logs directory that you've already excluded in .gitignore. The good news: your Java code is ready to use these appenders once configured - just add the configuration file to src/main/resources/ (e.g., log4j2.xml or log4j2.properties) and you're all set.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
| @@ -1,3 +1,4 @@ | |||
| .idea/* | |||
There was a problem hiding this comment.
The log4j2 configuration file (log4j2.xml or log4j2.properties) with File and Console appenders is not included in the submitted files. Per requirement #1, the logger must be configured with both appenders for logging to function properly.
|
I have already added a configuration file "src/main/resources/log4j2.xml". @mateacademy-ai-mentor |
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Your implementation meets all task requirements and is ready for merging.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
No description provided.