hw-jv-logger was completed#1228
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Great job integrating the logger into your Java classes and updating the .gitignore file! Your log messages in the service classes are informative and well-written.
However, this requires changes because a crucial part of the task is missing. The logger configuration file (e.g., log4j2.xml) was not included in your submission. This file is required to configure the logger with the specified File and Console appenders, which is a core requirement. Please add the necessary configuration file to your src/main/resources directory to complete the task.
Also, as a minor note, please ensure all files end with an empty line as mentioned in the checklist [CHECKLIST ITEM #2]. Keep up the good work!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
| user = authenticationService.login("bob", "1234"); | ||
| } catch (AuthenticationException e) { | ||
| e.printStackTrace(); | ||
| logger.error("Can't login", e); |
There was a problem hiding this comment.
This log message correctly captures the exception. To make it even more helpful for debugging, consider making it more informative as per checklist item #3. For example, you could include the username for which the login attempt failed. This might require defining the username in a variable outside the try block so it's accessible here in the catch block.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Excellent work on this revision! I am approving your solution as you've successfully addressed all the previous feedback. The critical log4j2.xml configuration file has been added, and the logger is now implemented correctly throughout the application with informative messages. The project now fully meets all task requirements. Great job!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
No description provided.