Skip to content

Solution made all tests passed#299

Open
ikhominitch wants to merge 2 commits into
mate-academy:masterfrom
ikhominitch:master
Open

Solution made all tests passed#299
ikhominitch wants to merge 2 commits into
mate-academy:masterfrom
ikhominitch:master

Conversation

@ikhominitch
Copy link
Copy Markdown

No description provided.

void calculate_addZero_Ok() {
double actual = calculator.calculate(0, -200, '+');
double expected = -200;
assertEquals(expected, actual);
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

однакові за своєю суттю асерти можна упустити

Comment on lines +343 to +344
void calculate_illegalOperation_NotOk() {
assertThrows(UnsupportedOperationException.class, () -> calculator.calculate(1, 1, '!'));
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
void calculate_illegalOperation_NotOk() {
assertThrows(UnsupportedOperationException.class, () -> calculator.calculate(1, 1, '!'));
void calculate_illegalOperation_NotOk() {
char unsupportedOperation = '!';
assertThrows(UnsupportedOperationException.class, () -> calculator.calculate(1, 1, unsupportedOperation));

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants