jv-lambda-calc task completed#288
Open
Gleb-Kreshchuk wants to merge 6 commits into
Open
Conversation
MAFIOZNIK1999
suggested changes
Sep 14, 2021
| return Math.pow(firstParameter, secondParameter); | ||
| case '/': | ||
| if (secondParameter == 0) { | ||
| throw new IllegalArgumentException("Division by zero"); |
There was a problem hiding this comment.
throw new ArithmeticException("Division by zero is not possible!");
Comment on lines
+8
to
+15
| class CalculatorTest { | ||
| private static final double DELTA = 0.0001; | ||
| private Calculate calculator = new Calculator(); | ||
|
|
||
| @Test | ||
| void additionWithTwoPositiveOperands_Ok() { | ||
| double expected = 100.0; | ||
| double actual = calculator.calculate(90.0, 10.0, '+'); |
There was a problem hiding this comment.
создай 1 раз expected and actual и используй их в каждом методе
| } | ||
|
|
||
| @Test | ||
| void additionWithFirstOperandIsZero_Ok() { |
There was a problem hiding this comment.
измени все названия методов по примеру calculate_additionPositiveAndNegativeOperand_ok
Comment on lines
+14
to
+15
| case '^': | ||
| return Math.pow(firstParameter, secondParameter); |
There was a problem hiding this comment.
а что если первый операнд 0, а второй -2?
Author
There was a problem hiding this comment.
добавлена проверка Double.POSITIVE_INFINITY
# Conflicts: # src/main/java/core/basesyntax/Calculator.java # src/test/java/core/basesyntax/CalculatorTest.java
MAFIOZNIK1999
approved these changes
Sep 14, 2021
# Conflicts: # src/main/java/core/basesyntax/Calculator.java # src/test/java/core/basesyntax/CalculatorTest.java
Max-Pochepets
approved these changes
Sep 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.